From 397b5693c4b354349ade15eab09baa5dde744f1c Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Wed, 21 May 2025 17:22:32 +0200 Subject: [SharedCache] Fix .dylddata sections failing to propagate constants This occurred because prior to the change made in build `7484` we short-circuited when the pointer pointed to a read only segment, now that we consult the section the sections semantics were incorrect and failed, this fixes the dyld data sections to have correct semantics. --- view/sharedcache/core/SharedCache.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'view/sharedcache/core/SharedCache.cpp') diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp index e4689086..0198ac48 100644 --- a/view/sharedcache/core/SharedCache.cpp +++ b/view/sharedcache/core/SharedCache.cpp @@ -368,7 +368,7 @@ void SharedCache::ProcessEntryRegions(const CacheEntry& entry) mappingRegion.start = mapping.address; mappingRegion.size = mapping.size; mappingRegion.name = fmt::format("{}::_data_{}", entry.GetFileName(), lastMappingIndex++); - mappingRegion.flags = SegmentReadable; + mappingRegion.flags = static_cast(SegmentReadable | SegmentDenyWrite); mappingRegion.type = CacheRegionType::DyldData; // Add the dyld data mapping as a region to the cache. -- cgit v1.3.1