From 8dd4e14da7ddd182a7fd9ea9437b7135f0c5cd9e Mon Sep 17 00:00:00 2001
From: Mason Reed <mason@vector35.com>
Date: Tue, 11 Feb 2025 21:51:05 -0500
Subject: [SharedCache] Always initialize logger first

Potential nullptr deref on invalid view type (see the error log right after the logger init)
---
 view/sharedcache/core/SharedCache.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'view/sharedcache/core/SharedCache.cpp')

diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp
index e4d5c5cf..2eae9d44 100644
--- a/view/sharedcache/core/SharedCache.cpp
+++ b/view/sharedcache/core/SharedCache.cpp
@@ -1363,6 +1363,7 @@ void SharedCache::ParseAndApplySlideInfoForFile(std::shared_ptr<MMappedFileAcces
 
 SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) : m_dscView(dscView), m_viewSpecificState(ViewSpecificStateForView(dscView))
 {
+	m_logger = LogRegistry::GetLogger("SharedCache", dscView->GetFile()->GetSessionId());
 	if (dscView->GetTypeName() != VIEW_NAME)
 	{
 		// Unreachable?
@@ -1371,7 +1372,6 @@ SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) : m_
 	}
 	sharedCacheReferences++;
 	INIT_SHAREDCACHE_API_OBJECT()
-	m_logger = LogRegistry::GetLogger("SharedCache", dscView->GetFile()->GetSessionId());
 	DeserializeFromRawView();
 	if (!m_metadataValid)
 		return;
-- 
cgit v1.3.1