From 0f26e9236d52e5e2f0a8e64114d954a516cbeb95 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Tue, 8 Apr 2025 14:16:05 -0400 Subject: [SharedCache] Apply demangled names and types more broadly Fixes the case of stub functions being applied with mangled names. --- view/sharedcache/core/SharedCache.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'view/sharedcache/core/SharedCache.h') diff --git a/view/sharedcache/core/SharedCache.h b/view/sharedcache/core/SharedCache.h index 3211b90c..0bf04776 100644 --- a/view/sharedcache/core/SharedCache.h +++ b/view/sharedcache/core/SharedCache.h @@ -31,8 +31,10 @@ struct CacheSymbol CacheSymbol& operator=(CacheSymbol&& other) noexcept = default; + std::pair> DemangledName(BinaryNinja::BinaryView& view) const; + // NOTE: you should really only call this when adding the symbol to the view. - BinaryNinja::Ref ToBNSymbol(BinaryNinja::BinaryView& view) const; + std::pair, BinaryNinja::Ref> GetBNSymbolAndType(BinaryNinja::BinaryView& view) const; }; enum class CacheRegionType @@ -151,11 +153,8 @@ public: CacheEntry& operator=(CacheEntry&&) = default; // Construct a cache entry from the file on disk. - // TODO: Seperate this out a bit more. static std::optional FromFile(const std::string& filePath, const std::string& fileName, CacheEntryType type); - // TODO: From Project file? - WeakFileAccessor GetAccessor() const; // Get the headers virtual address. -- cgit v1.3.1