From 477e3221a82ce5f96b3083e7415492d5da6fc9b4 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Wed, 19 Feb 2025 09:54:09 -0800 Subject: [SharedCache] Don't capture `this` within lambda passed to MMappedFileAccessor::Open Nothing guarantees that the `SharedCache` lives long enough. --- view/sharedcache/core/SharedCache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'view/sharedcache/core/SharedCache.h') diff --git a/view/sharedcache/core/SharedCache.h b/view/sharedcache/core/SharedCache.h index c1026295..f6a1e7a8 100644 --- a/view/sharedcache/core/SharedCache.h +++ b/view/sharedcache/core/SharedCache.h @@ -596,7 +596,7 @@ namespace SharedCacheCore { bool SaveCacheInfoToDSCView(std::lock_guard&); bool SaveModifiedStateToDSCView(std::lock_guard&); - void ParseAndApplySlideInfoForFile(std::shared_ptr file, uint64_t baseAddress); + static void ParseAndApplySlideInfoForFile(std::shared_ptr file, uint64_t baseAddress, Ref logger); std::optional GetImageStart(std::string_view installName); const SharedCacheMachOHeader* HeaderForAddress(uint64_t); bool LoadImageWithInstallName(std::string installName, bool skipObjC); -- cgit v1.3.1