From 664bdcd29761844ba9558f9c5fd43949009424e3 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Mon, 14 Apr 2025 01:44:28 -0400 Subject: [SharedCache] Fix project folder comparison crash Fixes https://github.com/Vector35/binaryninja-api/issues/6629 --- view/sharedcache/core/SharedCacheBuilder.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'view/sharedcache/core/SharedCacheBuilder.cpp') diff --git a/view/sharedcache/core/SharedCacheBuilder.cpp b/view/sharedcache/core/SharedCacheBuilder.cpp index 5c3ea0d8..ac2990fa 100644 --- a/view/sharedcache/core/SharedCacheBuilder.cpp +++ b/view/sharedcache/core/SharedCacheBuilder.cpp @@ -83,9 +83,8 @@ size_t SharedCacheBuilder::AddProjectFolder(Ref folder) const auto currentFileName = file.GetName(); // Skip files not in the folder. - if (const auto currentFolder = file.GetFolder(); folder) - if (currentFolder->GetId() != folder->GetId()) - return false; + if (!IsSameFolder(file.GetFolder(), folder)) + return false; // Ok, we are now _sure_ that this file _might_ be a part of the cache, lets try and process it! return AddFile(currentFilePath, currentFileName, CacheEntryType::Secondary); -- cgit v1.3.1