From b0965fa2a5c703214f60a6c5af01f6ddf21e6f42 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Sat, 3 May 2025 07:42:51 -0700 Subject: [SharedCache] Add activities to core.function.metaAnalysis rather than a new named workflow Activities are registered with a `viewType` predicate to ensure they only run in shared cache views. Adding activities to `core.function.metaAnalysis` lets activities registered by plug-ins run in the shared cache without the plug-ins having to be aware of the shared cache. Work towards #6779. --- view/sharedcache/core/SharedCacheView.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'view/sharedcache/core/SharedCacheView.cpp') diff --git a/view/sharedcache/core/SharedCacheView.cpp b/view/sharedcache/core/SharedCacheView.cpp index 49c1c846..b226e302 100644 --- a/view/sharedcache/core/SharedCacheView.cpp +++ b/view/sharedcache/core/SharedCacheView.cpp @@ -241,11 +241,11 @@ bool SharedCacheView::Init() Ref programSettings = Settings::Instance(); auto previousWorkflow = programSettings->Get("analysis.workflows.functionWorkflow", this); - // If we are a new file (not a database) lets go ahead and set the function workflow. - // We do not set the workflow on database as the user might have changed it in load options prior. - // We also need to update usages of `core.function.dsc` to `core.function.sharedCache` - if (!GetFile()->IsBackedByDatabase() || previousWorkflow == "core.function.dsc") - programSettings->Set("analysis.workflows.functionWorkflow", "core.function.sharedCache", this); + // Earlier versions of the shared cache plug-in used a named workflow rather than + // modifying `core.function.metaAnalysis`. Update reference to those older workflow + // names to `core.function.metaAnalysis`. + if (previousWorkflow == "core.function.dsc" || previousWorkflow == "core.function.sharedCache") + programSettings->Set("analysis.workflows.functionWorkflow", "core.function.metaAnalysis", this); } if (m_parseOnly) -- cgit v1.3.1