From b3cfd46356af3416d72bd6593bb2a397e72554b6 Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Tue, 18 Feb 2025 18:03:06 -0500 Subject: [SharedCache] Fix loading DSC BNDB from a local project crashing Also fixes a BinaryViewRef leak --- view/sharedcache/core/VM.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'view/sharedcache/core/VM.h') diff --git a/view/sharedcache/core/VM.h b/view/sharedcache/core/VM.h index 44bd5e63..e245751a 100644 --- a/view/sharedcache/core/VM.h +++ b/view/sharedcache/core/VM.h @@ -79,7 +79,7 @@ public: std::string_view filePath() const { return m_filePath; } private: - std::string m_filePath; + std::string m_filePath; }; uint64_t MMapCount(); @@ -93,7 +93,7 @@ public: MMappedFileAccessor(const std::string &path); ~MMappedFileAccessor(); - static std::shared_ptr Open(BinaryNinja::Ref dscView, const uint64_t sessionID, const std::string &path, std::function)> postAllocationRoutine = nullptr); + static std::shared_ptr Open(const uint64_t sessionID, const std::string &path, std::function)> postAllocationRoutine = nullptr); static void CloseAll(const uint64_t sessionID); @@ -163,7 +163,7 @@ class FileAccessorCache public: static FileAccessorCache& Shared(); - std::shared_ptr OpenLazily(BinaryNinja::Ref dscView, + std::shared_ptr OpenLazily( const uint64_t sessionID, const std::string& path, std::function)> postAllocationRoutine); @@ -173,7 +173,7 @@ private: FileAccessorCache(); std::shared_ptr Open( - BinaryNinja::Ref dscView, const uint64_t sessionID, const std::string& path); + const uint64_t sessionID, const std::string& path); void Close(MMappedFileAccessor* accessor); -- cgit v1.3.1