From 1457e9542f2398a058881f926d9f4d650e2d9f42 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Thu, 3 Apr 2025 15:42:41 -0400 Subject: [SharedCache] Misc triage view bug fixes - Fix the inconsistent column sizing - Stop trying to show cross reference at 0 --- view/sharedcache/ui/dsctriage.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'view/sharedcache/ui/dsctriage.cpp') diff --git a/view/sharedcache/ui/dsctriage.cpp b/view/sharedcache/ui/dsctriage.cpp index 642fc5df..09b075f0 100644 --- a/view/sharedcache/ui/dsctriage.cpp +++ b/view/sharedcache/ui/dsctriage.cpp @@ -335,8 +335,8 @@ DSCTriageView::DSCTriageView(QWidget* parent, BinaryViewRef data) : QWidget(pare mappingTable->setModel(m_mappingModel); - mappingTable->horizontalHeader()->setSectionResizeMode(0, QHeaderView::ResizeToContents); - mappingTable->horizontalHeader()->setSectionResizeMode(1, QHeaderView::ResizeToContents); + mappingTable->horizontalHeader()->setSectionResizeMode(0, QHeaderView::Fixed); + mappingTable->horizontalHeader()->setSectionResizeMode(1, QHeaderView::Fixed); mappingTable->horizontalHeader()->setSectionResizeMode(2, QHeaderView::ResizeToContents); mappingTable->horizontalHeader()->setSectionResizeMode(3, QHeaderView::Stretch); @@ -358,8 +358,8 @@ DSCTriageView::DSCTriageView(QWidget* parent, BinaryViewRef data) : QWidget(pare regionTable->setModel(m_regionModel); - regionTable->horizontalHeader()->setSectionResizeMode(0, QHeaderView::ResizeToContents); - regionTable->horizontalHeader()->setSectionResizeMode(1, QHeaderView::ResizeToContents); + regionTable->horizontalHeader()->setSectionResizeMode(0, QHeaderView::Fixed); + regionTable->horizontalHeader()->setSectionResizeMode(1, QHeaderView::Fixed); regionTable->horizontalHeader()->setSectionResizeMode(2, QHeaderView::Interactive); regionTable->horizontalHeader()->setSectionResizeMode(3, QHeaderView::Stretch); @@ -453,6 +453,14 @@ uint64_t DSCTriageView::getCurrentOffset() return 0; } +SelectionInfoForXref DSCTriageView::getSelectionForXref() +{ + // TODO: If we are in the symbols view we _can_ actually show a useful xref to the selected symbols. + SelectionInfoForXref selection = {}; + selection.addrValid = false; + return selection; +} + void DSCTriageView::OnAfterOpenFile(UIContext *context, FileContext *file, ViewFrame *frame) { RefreshData(); -- cgit v1.3.1