From b0965fa2a5c703214f60a6c5af01f6ddf21e6f42 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Sat, 3 May 2025 07:42:51 -0700 Subject: [SharedCache] Add activities to core.function.metaAnalysis rather than a new named workflow Activities are registered with a `viewType` predicate to ensure they only run in shared cache views. Adding activities to `core.function.metaAnalysis` lets activities registered by plug-ins run in the shared cache without the plug-ins having to be aware of the shared cache. Work towards #6779. --- view/sharedcache/workflow/ObjCActivity.cpp | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) (limited to 'view/sharedcache/workflow/ObjCActivity.cpp') diff --git a/view/sharedcache/workflow/ObjCActivity.cpp b/view/sharedcache/workflow/ObjCActivity.cpp index cc1b2256..f3efbccd 100644 --- a/view/sharedcache/workflow/ObjCActivity.cpp +++ b/view/sharedcache/workflow/ObjCActivity.cpp @@ -7,8 +7,21 @@ using namespace BinaryNinja; void ObjCActivity::Register(Workflow &workflow) { - workflow.RegisterActivity(new Activity("core.analysis.objc.adjustCallType", &AdjustCallType)); - workflow.Insert("core.function.analyzeTailCalls", "core.analysis.objc.adjustCallType"); + workflow.RegisterActivity(new Activity(R"({ + "name": "core.analysis.sharedCache.objc.adjustCallType", + "eligibility": { + "predicates": [ + { + "type": "viewType", + "operator": "in", + "value": [ + "DSCView" + ] + } + ] + } + })", &AdjustCallType)); + workflow.Insert("core.function.analyzeTailCalls", "core.analysis.sharedCache.objc.adjustCallType"); } std::vector splitSelector(const std::string& selector) { -- cgit v1.3.1