From 5552506894018ebc1ec5ae4d262d415dc6573ade Mon Sep 17 00:00:00 2001
From: Mason Reed <mason@vector35.com>
Date: Tue, 1 Apr 2025 15:59:51 -0400
Subject: [SharedCache] Improper nesting in workflow

oops!
---
 view/sharedcache/workflow/SharedCacheWorkflow.cpp | 30 +++++++++++------------
 1 file changed, 15 insertions(+), 15 deletions(-)

(limited to 'view/sharedcache/workflow/SharedCacheWorkflow.cpp')

diff --git a/view/sharedcache/workflow/SharedCacheWorkflow.cpp b/view/sharedcache/workflow/SharedCacheWorkflow.cpp
index 4c2f6d51..843194c6 100644
--- a/view/sharedcache/workflow/SharedCacheWorkflow.cpp
+++ b/view/sharedcache/workflow/SharedCacheWorkflow.cpp
@@ -368,25 +368,25 @@ void FixupOffImageCalls(Ref<AnalysisContext> ctx)
 							}
 						}
 					}
-					else if (destExpr.operation == MLIL_CONST_PTR)
+				}
+				else if (destExpr.operation == MLIL_CONST_PTR)
+				{
+					// 4 @ 18aa08208  (MLIL_JUMP jump((MLIL_CONST_PTR.q 0x18c1369f0)))
+					auto targetAddr = destExpr.GetConstant();
+					if (!view->IsValidOffset(targetAddr))
 					{
-						// 4 @ 18aa08208  (MLIL_JUMP jump((MLIL_CONST_PTR.q 0x18c1369f0)))
-						auto targetAddr = destExpr.GetConstant();
-						if (!view->IsValidOffset(targetAddr))
-						{
-							tryAddRegion(targetAddr);
-						}
+						tryAddRegion(targetAddr);
 					}
-					else if (destExpr.operation == MLIL_LOAD_SSA)
+				}
+				else if (destExpr.operation == MLIL_LOAD_SSA)
+				{
+					auto ptrExpr = destExpr.GetSourceExpr<MLIL_LOAD_SSA>();
+					if (ptrExpr.operation == MLIL_CONST_PTR)
 					{
-						auto ptrExpr = destExpr.GetSourceExpr<MLIL_LOAD_SSA>();
-						if (ptrExpr.operation == MLIL_CONST_PTR)
+						auto targetAddr = ptrExpr.GetConstant();
+						if (!view->IsValidOffset(targetAddr))
 						{
-							auto targetAddr = ptrExpr.GetConstant();
-							if (!view->IsValidOffset(targetAddr))
-							{
-								tryAddRegion(targetAddr);
-							}
+							tryAddRegion(targetAddr);
 						}
 					}
 				}
-- 
cgit v1.3.1