From 12486a2472aef8a60c5fce5b62bc516120075c36 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Tue, 15 Jul 2025 18:35:20 -0700 Subject: Fix leaks from the Workflow constructor Don't add an additional reference to the wrapped object in the constructor. API wrapper objects are passed a +1 object and do not need to add an additional reference. All clients of the Workflow constructors are doing this already which was resulting in leaks. Fixes https://github.com/Vector35/binaryninja-api/issues/7059. --- workflow.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'workflow.cpp') diff --git a/workflow.cpp b/workflow.cpp index 83e7b142..03a10c54 100644 --- a/workflow.cpp +++ b/workflow.cpp @@ -392,20 +392,20 @@ Workflow::Workflow(const string& name) Workflow::Workflow(BNWorkflow* workflow) { - m_object = BNNewWorkflowReference(workflow); + m_object = workflow; } Workflow::Workflow(BNWorkflow* workflow, Ref view) { - m_object = BNNewWorkflowReference(workflow); + m_object = workflow; m_machine = make_unique(view); } Workflow::Workflow(BNWorkflow* workflow, Ref function) { - m_object = BNNewWorkflowReference(workflow); + m_object = workflow; m_machine = make_unique(function); } -- cgit v1.3.1