diff options
| author | Glenn Smith <glenn@vector35.com> | 2025-04-16 15:05:05 -0400 |
|---|---|---|
| committer | Glenn Smith <glenn@vector35.com> | 2025-04-16 16:20:48 -0400 |
| commit | 3531638032799665736271701811868126402337 (patch) | |
| tree | ab2575c33033109f7ceea8677ca3a45702668cc6 | |
| parent | 1762153827196541115133495073244354362653 (diff) | |
Clean up navigable views and priorities
| -rw-r--r-- | examples/triage/view.cpp | 4 | ||||
| -rw-r--r-- | view/kernelcache/ui/kctriage.cpp | 5 | ||||
| -rw-r--r-- | view/sharedcache/ui/dsctriage.cpp | 3 |
3 files changed, 6 insertions, 6 deletions
diff --git a/examples/triage/view.cpp b/examples/triage/view.cpp index bea5b827..e2524aac 100644 --- a/examples/triage/view.cpp +++ b/examples/triage/view.cpp @@ -290,7 +290,9 @@ int TriageViewType::getPriority(BinaryViewRef data, const QString&) return 100; if (data->GetLength() > 0) { - if (alwaysPrefer || data->IsExecutable() || preferForRaw) + if (alwaysPrefer || preferForRaw) + return 35; + if (data->IsExecutable()) return 25; return 1; } diff --git a/view/kernelcache/ui/kctriage.cpp b/view/kernelcache/ui/kctriage.cpp index 6f590190..5103bc51 100644 --- a/view/kernelcache/ui/kctriage.cpp +++ b/view/kernelcache/ui/kctriage.cpp @@ -38,7 +38,7 @@ void KCTriageViewType::Register() KCTriageView::KCTriageView(QWidget* parent, BinaryViewRef data) : QWidget(parent), View(), m_data(data), m_cache(new KernelCache(data)) { - setBinaryDataNavigable(true); + setBinaryDataNavigable(false); setupView(this); UIContext::registerNotification(this); @@ -367,8 +367,7 @@ BinaryViewRef KCTriageView::getData() bool KCTriageView::navigate(uint64_t offset) { - // TODO: We have to set this to true otherwise view restore does not pickup this view. - return true; + return false; } diff --git a/view/sharedcache/ui/dsctriage.cpp b/view/sharedcache/ui/dsctriage.cpp index c352254c..2d741807 100644 --- a/view/sharedcache/ui/dsctriage.cpp +++ b/view/sharedcache/ui/dsctriage.cpp @@ -470,8 +470,7 @@ BinaryViewRef DSCTriageView::getData() bool DSCTriageView::navigate(uint64_t offset) { - // TODO: We have to set this to true otherwise view restore does not pickup this view. - return true; + return false; } |