diff options
| author | Mason Reed <mason@vector35.com> | 2024-11-25 18:40:54 -0500 |
|---|---|---|
| committer | Mason Reed <mason@vector35.com> | 2025-01-03 13:36:22 -0500 |
| commit | 3c05103cfaca688f3961b78043e01b1353a238c7 (patch) | |
| tree | 27af8f7d60ecfcd27b872e8ca0f90c0082f9cbfb | |
| parent | 958c87b41aa12d15d85e9649cf6542efd97cf9e7 (diff) | |
Delete ViewNavigationMode
Does not seem to do anything other than cause a crash!
| -rw-r--r-- | ui/viewframe.h | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/ui/viewframe.h b/ui/viewframe.h index 520e3f77..2cbaeacf 100644 --- a/ui/viewframe.h +++ b/ui/viewframe.h @@ -122,15 +122,6 @@ class BINARYNINJAUIAPI View bool writeDataToClipboard(const BinaryNinja::DataBuffer& data, bool binary, TransformRef xform); BinaryNinja::DataBuffer readDataFromClipboard(TransformRef xform); - // FIXME: Support for typeview, where the default navigation mode is not compatible with the navigation interface - // The view concept and navigation interface needs to be revisited at some point - // New interface/design should be pushed to NavigationHandler and through API - // The empty string is global navigation (inside view) by default, allows offset to be interpreted by mode - friend class ViewNavigationMode; - virtual std::string getNavigationMode() { return ""; } - virtual void setNavigationMode(std::string mode) { (void)mode; } - virtual std::vector<std::string> getNavigationModes() { return {}; } - public: View(); virtual ~View() {} @@ -259,25 +250,6 @@ class BINARYNINJAUIAPI View void notifyContextMenuCreated(); }; -/*! - - \ingroup viewframe -*/ -class BINARYNINJAUIAPI ViewNavigationMode -{ - View* m_view; - std::string m_mode; - - ViewNavigationMode(); - - public: - ViewNavigationMode(View* view, std::string mode) : m_view(view) - { - m_mode = m_view->getNavigationMode(); - m_view->setNavigationMode(mode); - } - ~ViewNavigationMode() { m_view->setNavigationMode(m_mode); } -}; /*! |