summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRusty Wagner <rusty.wagner@gmail.com>2023-01-23 11:59:09 -0700
committerRusty Wagner <rusty.wagner@gmail.com>2023-01-23 16:16:19 -0700
commit53ab17fbf4f5210fece91d601b15cab069fbb41f (patch)
tree0deae2d24c651b2bcb78aaecf34b0d7959a2549a
parent9528390a74e0178efe1b422258f9dfb60072dc4c (diff)
Warning cleanup
-rw-r--r--enterprise.cpp2
-rw-r--r--examples/triage/librariesinfo.cpp1
-rw-r--r--lowlevelil.cpp6
-rw-r--r--ui/metadatachoicedialog.h4
4 files changed, 6 insertions, 7 deletions
diff --git a/enterprise.cpp b/enterprise.cpp
index 07f3ff82..3a25162c 100644
--- a/enterprise.cpp
+++ b/enterprise.cpp
@@ -237,7 +237,7 @@ BinaryNinja::EnterpriseServer::LicenseCheckout::LicenseCheckout(int64_t duration
// Keychain auth can activate a license if we have one in the keychain
// If we have an expired named license, try to get a fresh floating one
- if (!IsLicenseStillActivated() || (!IsFloatingLicense() && BNGetLicenseExpirationTime() < time(nullptr)))
+ if (!IsLicenseStillActivated() || (!IsFloatingLicense() && (time_t)BNGetLicenseExpirationTime() < time(nullptr)))
{
if (!EnterpriseServer::AcquireLicense(duration))
{
diff --git a/examples/triage/librariesinfo.cpp b/examples/triage/librariesinfo.cpp
index 03764e99..e50120df 100644
--- a/examples/triage/librariesinfo.cpp
+++ b/examples/triage/librariesinfo.cpp
@@ -18,7 +18,6 @@ LibrariesWidget::LibrariesWidget(QWidget* parent, BinaryViewRef bv)
auto lib = libNames[i];
auto typeLib = typeLibPaths[i];
auto libWidget = new QLabel(QString::fromStdString(" " + lib));
- QColor textColor;
QString toolTip;
auto style = QPalette(palette());
if (typeLib.empty())
diff --git a/lowlevelil.cpp b/lowlevelil.cpp
index 6f1025e7..dfb53e5b 100644
--- a/lowlevelil.cpp
+++ b/lowlevelil.cpp
@@ -126,7 +126,7 @@ std::vector<uint32_t> LowLevelILFunction::GetRegisters()
return result;
result.reserve(count);
- for (auto i = 0; i < count; i++)
+ for (size_t i = 0; i < count; i++)
{
result.push_back(regs[i]);
}
@@ -146,7 +146,7 @@ std::vector<uint32_t> LowLevelILFunction::GetRegisterStacks()
return result;
result.reserve(count);
- for (auto i = 0; i < count; i++)
+ for (size_t i = 0; i < count; i++)
{
result.push_back(regs[i]);
}
@@ -166,7 +166,7 @@ std::vector<uint32_t> LowLevelILFunction::GetFlags()
return result;
result.reserve(count);
- for (auto i = 0; i < count; i++)
+ for (size_t i = 0; i < count; i++)
{
result.push_back(regs[i]);
}
diff --git a/ui/metadatachoicedialog.h b/ui/metadatachoicedialog.h
index c75320ee..e2d07a14 100644
--- a/ui/metadatachoicedialog.h
+++ b/ui/metadatachoicedialog.h
@@ -74,7 +74,7 @@ class ManagedTableView : public QTableView, public FilterTarget
public:
ManagedTableView(QWidget* parent, const QStringList& entries);
- size_t getCurrentSelection();
+ int getCurrentSelection();
void forceFilterUpdate() {
setFilter(m_filter);
@@ -240,7 +240,7 @@ protected:
{ return m_contextMenuItems; };
virtual void ExecuteContextMenuItem(size_t menuItemIndex, size_t idx) override;
virtual bool EntryItemPassesExtraFilters(EntryItem& item) override;
- virtual std::vector<EntryItem> GetAllItems() const { return m_entries; };
+ virtual std::vector<EntryItem> GetAllItems() const override { return m_entries; };
struct ExtraFilterState {
bool exists = false;