Introduce a new define to control LogTrace rather than using _DEBUG

Defining `_DEBUG` changes which MSVC runtime library needs to be linked
which breaks clients attempting to use the C++ API with `RelWithDebInfo`.
To fix this we define a new private `BN_ENABLE_LOG_TRACE` macro and use
that within log.cpp where it was previously using `_DEBUG`.

Fixes https://github.com/Vector35/binaryninja-api/issues/7288.

2 files changed, 9 insertions, 11 deletions

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3a28b964..197897a6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -63,9 +63,7 @@ if(BN_REF_COUNT_DEBUG)
 endif()
 
 if(CMAKE_BUILD_TYPE MATCHES Debug OR CMAKE_BUILD_TYPE MATCHES RelWithDebInfo)
-    target_compile_definitions(binaryninjaapi PRIVATE _DEBUG)
-else()
-    target_compile_definitions(binaryninjaapi PRIVATE NDEBUG)
+    target_compile_definitions(binaryninjaapi PRIVATE BN_ENABLE_LOG_TRACE)
 endif()
 
 add_subdirectory(vendor/fmt EXCLUDE_FROM_ALL)
diff --git a/log.cpp b/log.cpp
index 2329e503..e6abe48b 100644
--- a/log.cpp
+++ b/log.cpp
@@ -215,7 +215,7 @@ void BinaryNinja::Log(BNLogLevel level, const char* fmt, ...)
 
 void BinaryNinja::LogTrace(const char* fmt, ...)
 {
-#ifdef _DEBUG
+#ifdef BN_ENABLE_LOG_TRACE
 	va_list args;
 	va_start(args, fmt);
 	PerformLog(0, DebugLog, "", 0, fmt, args);
@@ -280,7 +280,7 @@ void BinaryNinja::LogForException(BNLogLevel level, const std::exception& e, con
 
 void BinaryNinja::LogTraceForException(const std::exception& e, const char* fmt, ...)
 {
-#ifdef _DEBUG
+#ifdef BN_ENABLE_LOG_TRACE
 	va_list args;
 	va_start(args, fmt);
 	PerformLogForException(0, DebugLog, "", 0, e, fmt, args);
@@ -345,12 +345,12 @@ void BinaryNinja::LogWithStackTrace(BNLogLevel level, const char* fmt, ...)
 
 void BinaryNinja::LogTraceWithStackTrace(const char* fmt, ...)
 {
-	#ifdef _DEBUG
+#ifdef BN_ENABLE_LOG_TRACE
 	va_list args;
 	va_start(args, fmt);
 	PerformLogWithStackTrace(0, DebugLog, "", 0, fmt, args);
 	va_end(args);
-	#endif
+#endif
 }
 
 
@@ -493,7 +493,7 @@ void Logger::Log(BNLogLevel level, const char* fmt, ...)
 
 void Logger::LogTrace(const char* fmt, ...)
 {
-#ifdef _DEBUG
+#ifdef BN_ENABLE_LOG_TRACE
 	va_list args;
 	va_start(args, fmt);
 	PerformLog(GetSessionId(), DebugLog, GetName(), GetThreadId(), fmt::format("{}{}", GetIndent(), fmt).c_str(), args);
@@ -559,7 +559,7 @@ void Logger::LogForException(BNLogLevel level, const std::exception& e, const ch
 
 void Logger::LogTraceForException(const std::exception& e, const char* fmt, ...)
 {
-#ifdef _DEBUG
+#ifdef BN_ENABLE_LOG_TRACE
 	va_list args;
 	va_start(args, fmt);
 	PerformLogForException(
@@ -631,13 +631,13 @@ void Logger::LogWithStackTrace(BNLogLevel level, const char* fmt, ...)
 
 void Logger::LogTraceWithStackTrace(const char* fmt, ...)
 {
-	#ifdef _DEBUG
+#ifdef BN_ENABLE_LOG_TRACE
 	va_list args;
 	va_start(args, fmt);
 	PerformLogWithStackTrace(
 		GetSessionId(), DebugLog, GetName(), GetThreadId(), fmt::format("{}{}", GetIndent(), fmt).c_str(), args);
 	va_end(args);
-	#endif
+#endif
 }