summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRusty Wagner <rusty.wagner@gmail.com>2023-09-26 18:56:47 -0600
committerRusty Wagner <rusty.wagner@gmail.com>2023-09-28 13:32:49 -0600
commit8b15f2244af51ef312a6a4be7444a07242a34b60 (patch)
tree70958ceffbfb9c38db1d170cdf642084a80c5607
parent32501cd8b0879f53ed4a24a96aad4c1b71080193 (diff)
Minor updates for Python binding generation of UI API
-rw-r--r--ui/typedialog.h2
-rw-r--r--ui/uicomment.h2
-rw-r--r--ui/uicontext.h3
-rw-r--r--ui/viewframe.h2
4 files changed, 4 insertions, 5 deletions
diff --git a/ui/typedialog.h b/ui/typedialog.h
index c8768559..1825fdb5 100644
--- a/ui/typedialog.h
+++ b/ui/typedialog.h
@@ -115,6 +115,6 @@ class BINARYNINJAUIAPI TypeDialog : public QDialog
public:
TypeDialog(QWidget* parent, BinaryViewRef view, const QString& title = "Specify Type",
const QString& prompt = "Enter Type Name", const QString& existing = "");
- ~TypeDialog() { delete m_updateThread; }
+ ~TypeDialog();
BinaryNinja::QualifiedNameAndType getType() const { return m_type; }
};
diff --git a/ui/uicomment.h b/ui/uicomment.h
index 2856c3c0..b8265fb0 100644
--- a/ui/uicomment.h
+++ b/ui/uicomment.h
@@ -25,7 +25,7 @@ typedef enum
\ingroup uicomment
*/
-class UIComment
+class BINARYNINJAUIAPI UIComment
{
public:
UICommentType type;
diff --git a/ui/uicontext.h b/ui/uicontext.h
index e8a40a70..99abb84e 100644
--- a/ui/uicontext.h
+++ b/ui/uicontext.h
@@ -273,9 +273,8 @@ class BINARYNINJAUIAPI UIContext
void NotifyOnViewChange(ViewFrame* frame, const QString& type);
void NotifyOnAddressChange(ViewFrame* frame, View* view, const ViewLocation& location);
- void NotifyOnNewSelectionForXref(ViewFrame* frame, View* view, const SelectionInfoForXref& selection);
- public:
+public:
UIContext();
virtual ~UIContext();
diff --git a/ui/viewframe.h b/ui/viewframe.h
index 96bf7d98..0a9f9020 100644
--- a/ui/viewframe.h
+++ b/ui/viewframe.h
@@ -27,7 +27,7 @@
\ingroup viewframe
*/
-struct SelectionInfoForXref
+struct BINARYNINJAUIAPI SelectionInfoForXref
{
// Check these booleans before accessing the address/type/variable info,
// since the invalid fields are not guaranteed to be initialized/zero-ed.