diff options
| author | Glenn Smith <glenn@vector35.com> | 2025-02-21 15:29:34 -0500 |
|---|---|---|
| committer | Mason Reed <mason@vector35.com> | 2025-04-02 05:36:54 -0400 |
| commit | 90e9ff91f02f2cb902bf0564de1f403e23172f36 (patch) | |
| tree | b9433f1943c43b4333bf45b8e2d69cccaf687d64 | |
| parent | 721d24be648eccae72fe97f89f0fbd18de36af8a (diff) | |
[SharedCache] Don't serialize state twice
| -rw-r--r-- | view/sharedcache/core/DSCView.cpp | 2 | ||||
| -rw-r--r-- | view/sharedcache/core/SharedCache.cpp | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/view/sharedcache/core/DSCView.cpp b/view/sharedcache/core/DSCView.cpp index aae1e3c4..c8f49378 100644 --- a/view/sharedcache/core/DSCView.cpp +++ b/view/sharedcache/core/DSCView.cpp @@ -614,7 +614,7 @@ bool DSCView::Init() Ref<Type> filesetEntryCommandType = Type::StructureType(filesetEntryCommandStruct); DefineType(filesetEntryCommandTypeId, filesetEntryCommandName, filesetEntryCommandType); - if (auto metadata = SharedCacheCore::SharedCacheMetadata::LoadFromView(GetParentView())) + if (auto metadata = SharedCacheCore::SharedCacheMetadata::LoadFromView(this)) { BeginBulkModifySymbols(); for (const auto& [imageBaseAddr, exportMap] : metadata->ExportInfos()) diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp index a5dd65d8..5709759b 100644 --- a/view/sharedcache/core/SharedCache.cpp +++ b/view/sharedcache/core/SharedCache.cpp @@ -3055,7 +3055,6 @@ bool SharedCache::SaveCacheInfoToDSCView(std::lock_guard<std::mutex>&) auto data = m_cacheInfo->AsMetadata(); m_dscView->StoreMetadata(SharedCacheMetadata::Tag, data); - m_dscView->GetParentView()->StoreMetadata(SharedCacheMetadata::Tag, data); { std::lock_guard lock(m_viewSpecificState->cacheInfoMutex); @@ -3092,7 +3091,6 @@ bool SharedCache::SaveModifiedStateToDSCView(std::lock_guard<std::mutex>&) auto data = m_viewSpecificState->state.AsMetadata(m_viewSpecificState->viewState); m_dscView->StoreMetadata(metadataKey, data); - m_dscView->GetParentView()->StoreMetadata(metadataKey, data); modificationNumber = m_viewSpecificState->savedModifications++; } @@ -3100,11 +3098,9 @@ bool SharedCache::SaveModifiedStateToDSCView(std::lock_guard<std::mutex>&) auto data = m_modifiedState->AsMetadata(); m_dscView->StoreMetadata(metadataKey, data); - m_dscView->GetParentView()->StoreMetadata(metadataKey, data); Ref<Metadata> count = new Metadata(m_viewSpecificState->savedModifications); m_dscView->StoreMetadata(SharedCacheMetadata::ModifiedStateCountTag, count); - m_dscView->GetParentView()->StoreMetadata(SharedCacheMetadata::ModifiedStateCountTag, count); m_viewSpecificState->state.exportInfos.merge(m_modifiedState->exportInfos); m_viewSpecificState->state.symbolInfos.merge(m_modifiedState->symbolInfos); |