Esure parse_types api raise proper exceptions

2 files changed, 6 insertions, 1 deletions

diff --git a/python/binaryview.py b/python/binaryview.py
index 2db75717..405afcc6 100644
--- a/python/binaryview.py
+++ b/python/binaryview.py
@@ -6203,7 +6203,7 @@ class BinaryView:
 			>>>
 		"""
 		if not isinstance(text, str):
-			raise AttributeError("Source must be a string")
+			raise ValueError("Source must be a string")
 
 		parse = core.BNTypeParserResult()
 		try:
diff --git a/suite/api_test.py b/suite/api_test.py
index 3fd3dbb0..c77b5fc9 100644
--- a/suite/api_test.py
+++ b/suite/api_test.py
@@ -2780,6 +2780,11 @@ class TestBinaryView(TestWithBinaryView):
 		assert a.return_value == b.return_value
 		assert a.parameters == b.parameters
 
+		self.assertRaises(ValueError, lambda: self.bv.parse_type_string(None))
+		self.assertRaises(SyntaxError, lambda: self.bv.parse_type_string("a"))
+		self.assertRaises(ValueError, lambda: self.bv.parse_types_from_string(None))
+		self.assertRaises(SyntaxError, lambda: self.bv.parse_types_from_string("a"))
+
 
 
 class TestBinaryViewType(unittest.TestCase):