[KernelCache] Wrap section creation within BeginBulkAddSegments / EndBulkAddSegments

This defers rebuilding of the section map until after all sections for
an image have been added, rather than having the section map be rebuilt
after adding each section.

1 files changed, 3 insertions, 0 deletions

diff --git a/view/kernelcache/core/MachOProcessor.cpp b/view/kernelcache/core/MachOProcessor.cpp
index 5731d80e..55afc408 100644
--- a/view/kernelcache/core/MachOProcessor.cpp
+++ b/view/kernelcache/core/MachOProcessor.cpp
@@ -31,12 +31,15 @@ void KernelCacheMachOProcessor::ApplyHeader(const KernelCache& cache, KernelCach
 	};
 
 	// Add a section for the header itself.
+	m_view->BeginBulkAddSegments();
 	std::string headerSection = fmt::format("{}::__macho_header", header.identifierPrefix);
 	uint64_t machHeaderSize = m_view->GetAddressSize() == 8 ? sizeof(mach_header_64) : sizeof(mach_header);
 	uint64_t headerSectionSize = machHeaderSize + header.ident.sizeofcmds;
 	m_view->AddUserSection(headerSection, header.textBase, headerSectionSize, ReadOnlyDataSectionSemantics);
 
 	ApplyHeaderSections(header);
+	m_view->EndBulkAddSegments();
+
 	ApplyHeaderDataVariables(header);
 
 	// Pull the available type library for the image we are loading, so we can apply known types.