Change tag ids to string

3 files changed, 6 insertions, 6 deletions

diff --git a/binaryninjaapi.h b/binaryninjaapi.h
index d0101b22..65a79fcd 100644
--- a/binaryninjaapi.h
+++ b/binaryninjaapi.h
@@ -1672,7 +1672,7 @@ __attribute__ ((format (printf, 1, 2)))
 
 		void AddTag(Ref<Tag> tag, bool user = false);
 		void RemoveTag(Ref<Tag> tag, bool user = false);
-		Ref<Tag> GetTag(uint64_t tagId);
+		Ref<Tag> GetTag(const std::string& tagId);
 
 		std::vector<TagReference> GetAllTagReferences();
 		std::vector<TagReference> GetAllAddressTagReferences();
diff --git a/binaryninjacore.h b/binaryninjacore.h
index 8a0cf7d5..0f0743fb 100644
--- a/binaryninjacore.h
+++ b/binaryninjacore.h
@@ -28,14 +28,14 @@
 // Current ABI version for linking to the core. This is incremented any time
 // there are changes to the API that affect linking, including new functions,
 // new types, or modifications to existing functions or types.
-#define BN_CURRENT_CORE_ABI_VERSION 10
+#define BN_CURRENT_CORE_ABI_VERSION 11
 
 // Minimum ABI version that is supported for loading of plugins. Plugins that
 // are linked to an ABI version less than this will not be able to load and
 // will require rebuilding. The minimum version is increased when there are
 // incompatible changes that break binary compatibility, such as changes to
 // existing types or functions.
-#define BN_MINIMUM_CORE_ABI_VERSION 10
+#define BN_MINIMUM_CORE_ABI_VERSION 11
 
 #ifdef __GNUC__
 #  ifdef BINARYNINJACORE_LIBRARY
@@ -3749,7 +3749,7 @@ __attribute__ ((format (printf, 1, 2)))
 	BINARYNINJACOREAPI BNTagType** BNGetTagTypes(BNBinaryView* view, size_t* count);
 
 	BINARYNINJACOREAPI void BNAddTag(BNBinaryView* view, BNTag* tag, bool user);
-	BINARYNINJACOREAPI BNTag* BNGetTag(BNBinaryView* view, uint64_t tagId);
+	BINARYNINJACOREAPI BNTag* BNGetTag(BNBinaryView* view, const char* tagId);
 	BINARYNINJACOREAPI void BNRemoveTag(BNBinaryView* view, BNTag* tag, bool user);
 
 	BINARYNINJACOREAPI BNTagReference* BNGetAllTagReferences(BNBinaryView* view, size_t* count);
diff --git a/binaryview.cpp b/binaryview.cpp
index 476b897b..63e73ad1 100644
--- a/binaryview.cpp
+++ b/binaryview.cpp
@@ -2431,9 +2431,9 @@ void BinaryView::RemoveTag(Ref<Tag> tag, bool user)
 }
 
 
-Ref<Tag> BinaryView::GetTag(uint64_t tagId)
+Ref<Tag> BinaryView::GetTag(const string& tagId)
 {
-	BNTag* tag = BNGetTag(m_object, tagId);
+	BNTag* tag = BNGetTag(m_object, tagId.c_str());
 	if (!tag)
 		return nullptr;