diff options
| author | Rusty Wagner <rusty.wagner@gmail.com> | 2025-06-24 17:55:48 -0400 |
|---|---|---|
| committer | Alexander Taylor <alex@vector35.com> | 2025-06-25 18:36:47 -0400 |
| commit | c41f264a1dba68c89b4a224a70e3a5783f7fa879 (patch) | |
| tree | 00bb6e91d86b708bff7265ed7179a6ef2793b7fb /arch/arm64/arch_arm64.cpp | |
| parent | b1a7666164a000c5255f90568ed9597b58ce276a (diff) | |
Remove implicit conversions from Confidence to underlying type, these can cause bugs and also issues with C++20
Diffstat (limited to 'arch/arm64/arch_arm64.cpp')
| -rw-r--r-- | arch/arm64/arch_arm64.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/arch/arm64/arch_arm64.cpp b/arch/arm64/arch_arm64.cpp index 1032c15c..b0e97995 100644 --- a/arch/arm64/arch_arm64.cpp +++ b/arch/arm64/arch_arm64.cpp @@ -2358,7 +2358,7 @@ class Arm64ImportedFunctionRecognizer : public FunctionRecognizer DataVariable var; if (data->GetDataVariableAtAddress(extSym.front()->GetAddress(), var)) { - func->ApplyImportedTypes(funcSym, var.type); + func->ApplyImportedTypes(funcSym, var.type.GetValue()); } return true; } @@ -2431,12 +2431,12 @@ class Arm64ImportedFunctionRecognizer : public FunctionRecognizer data->GetDataVariableAtAddress(loadAddrConstant.value, target); Ref<Type> funcType = nullptr; - if (target.type && target.type->GetClass() == PointerTypeClass && - target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) + if (target.type.GetValue() && target.type->GetClass() == PointerTypeClass + && target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) { target.type = target.type->GetChildType(); - if (target.type && target.type->GetClass() == FunctionTypeClass && - target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) + if (target.type.GetValue() && target.type->GetClass() == FunctionTypeClass + && target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) funcType = target.type.GetValue(); } @@ -2522,12 +2522,12 @@ class Arm64ImportedFunctionRecognizer : public FunctionRecognizer data->GetDataVariableAtAddress(loadAddrConstant.value, target); Ref<Type> funcType = nullptr; - if (target.type && target.type->GetClass() == PointerTypeClass && - target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) + if (target.type.GetValue() && target.type->GetClass() == PointerTypeClass + && target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) { target.type = target.type->GetChildType(); - if (target.type && target.type->GetClass() == FunctionTypeClass && - target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) + if (target.type.GetValue() && target.type->GetClass() == FunctionTypeClass + && target.type.GetConfidence() >= BN_MINIMUM_CONFIDENCE) funcType = target.type.GetValue(); } |