Fix a number of leaks and bad uses of free in the api

See https://github.com/Vector35/binaryninja-api/issues/4751

1 files changed, 16 insertions, 0 deletions

diff --git a/binaryview.cpp b/binaryview.cpp
index 077f2b4a..7abb01cb 100644
--- a/binaryview.cpp
+++ b/binaryview.cpp
@@ -769,6 +769,13 @@ std::vector<Ref<Tag>> Tag::ConvertTagList(BNTag** tags, size_t count)
 }
 
 
+void Tag::FreeTagList(BNTag** tags, size_t count)
+{
+	delete[] tags;
+	(void)count;
+}
+
+
 std::vector<Ref<Tag>> Tag::ConvertAndFreeTagList(BNTag** tags, size_t count)
 {
 	auto result = ConvertTagList(tags, count);
@@ -859,6 +866,13 @@ std::vector<TagReference> TagReference::ConvertTagReferenceList(BNTagReference*
 }
 
 
+void TagReference::FreeTagReferenceList(BNTagReference* tags, size_t count)
+{
+	delete[] tags;
+	(void)count;
+}
+
+
 std::vector<TagReference> TagReference::ConvertAndFreeTagReferenceList(BNTagReference* tags, size_t count)
 {
 	auto result = ConvertTagReferenceList(tags, count);
@@ -3621,6 +3635,7 @@ bool BinaryView::ParseTypeString(const string& source, map<QualifiedName, Ref<Ty
 		errors = errorStr;
 		BNFreeString(errorStr);
 	}
+	delete[] typesList.names;
 	if (!ok)
 		return false;
 
@@ -3675,6 +3690,7 @@ bool BinaryView::ParseTypesFromSource(const string& source, const vector<string>
 		errors = errorStr;
 		BNFreeString(errorStr);
 	}
+	delete[] typesList.names;
 	if (!ok)
 		return false;