diff options
| author | Rusty Wagner <rusty@vector35.com> | 2019-05-21 14:37:36 -0400 |
|---|---|---|
| committer | Rusty Wagner <rusty@vector35.com> | 2019-05-21 14:37:36 -0400 |
| commit | c885b7a4c47f16a1c69612215a1cab5c9f7df5eb (patch) | |
| tree | 4456c99de61177ef77b8994c5469e57a46a0cf09 /examples | |
| parent | 2b2aefb5dab8e56b32d718a3d2e388f56a4f65b0 (diff) | |
Bring Python triage plugin changes to C++, don't default to raw files always opening in triage view
Diffstat (limited to 'examples')
| -rw-r--r-- | examples/triage/files.cpp | 6 | ||||
| -rw-r--r-- | examples/triage/triage.cpp | 10 | ||||
| -rw-r--r-- | examples/triage/view.cpp | 4 |
3 files changed, 10 insertions, 10 deletions
diff --git a/examples/triage/files.cpp b/examples/triage/files.cpp index a736b81d..8ae97f33 100644 --- a/examples/triage/files.cpp +++ b/examples/triage/files.cpp @@ -82,11 +82,11 @@ void TriageFilePicker::openSelectedFiles() f->createBinaryViews(); for (auto data: f->getAllDataViews()) { - BinaryNinja::Settings().Set("analysis.mode", BinaryNinja::Settings().Get<std::string>("triage.analysis_mode"), data); - BinaryNinja::Settings().Set("triage.always_prefer", true, data); + BinaryNinja::Settings().Set("analysis.mode", BinaryNinja::Settings().Get<std::string>("triage.analysisMode"), data); + BinaryNinja::Settings().Set("triage.preferSummaryView", true, data); if (data->GetTypeName() != "Raw") { - std::string linearSweepMode = BinaryNinja::Settings().Get<std::string>("triage.linear_sweep"); + std::string linearSweepMode = BinaryNinja::Settings().Get<std::string>("triage.linearSweep"); if (linearSweepMode == "none") { BinaryNinja::Settings().Set("analysis.linearSweep.autorun", false, data); diff --git a/examples/triage/triage.cpp b/examples/triage/triage.cpp index d88180a0..37431d65 100644 --- a/examples/triage/triage.cpp +++ b/examples/triage/triage.cpp @@ -13,7 +13,7 @@ extern "C" #endif { BinaryNinja::Settings().RegisterGroup("triage", "Triage"); - BinaryNinja::Settings().RegisterSetting("triage.always_prefer", + BinaryNinja::Settings().RegisterSetting("triage.preferSummaryView", R"({ "title" : "Always Prefer Triage Summary View", "type" : "boolean", @@ -21,17 +21,17 @@ extern "C" "description" : "Always prefer opening binaries in Triage Summary view, even when performing full analysis." })"); - BinaryNinja::Settings().RegisterSetting("triage.prefer_for_raw", + BinaryNinja::Settings().RegisterSetting("triage.preferSummaryViewForRaw", R"({ "title" : "Prefer Triage Summary View for Raw Files", "type" : "boolean", - "default" : true, + "default" : false, "description" : "Prefer opening raw files in Triage Summary view." })"); ViewType::registerViewType(new TriageViewType()); - BinaryNinja::Settings().RegisterSetting("triage.analysis_mode", + BinaryNinja::Settings().RegisterSetting("triage.analysisMode", R"({ "title" : "Triage Analysis Mode", "type" : "string", @@ -44,7 +44,7 @@ extern "C" "Perform full analysis of the binary." ] })"); - BinaryNinja::Settings().RegisterSetting("triage.linear_sweep", + BinaryNinja::Settings().RegisterSetting("triage.linearSweep", R"({ "title" : "Triage Linear Sweep Mode", "type" : "string", diff --git a/examples/triage/view.cpp b/examples/triage/view.cpp index 73e036a5..e4077521 100644 --- a/examples/triage/view.cpp +++ b/examples/triage/view.cpp @@ -221,8 +221,8 @@ TriageViewType::TriageViewType(): ViewType("Triage", "Triage Summary") int TriageViewType::getPriority(BinaryViewRef data, const QString&) { bool full = BinaryNinja::Settings().Get<std::string>("analysis.mode", data) == "full"; - bool alwaysPrefer = BinaryNinja::Settings().Get<bool>("triage.always_prefer", data); - bool preferForRaw = BinaryNinja::Settings().Get<bool>("triage.prefer_for_raw", data); + bool alwaysPrefer = BinaryNinja::Settings().Get<bool>("triage.preferSummaryView", data); + bool preferForRaw = BinaryNinja::Settings().Get<bool>("triage.preferSummaryViewForRaw", data); if (data->IsExecutable() && (alwaysPrefer || !full)) return 100; if (data->GetLength() > 0) |
