Fix operand list iterators being validated when appending new instructions

The iterators now store an offset into the operand storage, rather than
a pointer. Deferencing the iterator retrieves the value at that offset
from the IL function.

This issue existed prior to the operand list storage refactor, but
became easier to hit after that change. The separate operand list vector
is smaller and thus more likely to reallocate when a new instruction is
appended.

1 files changed, 1 insertions, 1 deletions

diff --git a/highlevelilinstruction.h b/highlevelilinstruction.h
index 93152241..bf2b5162 100644
--- a/highlevelilinstruction.h
+++ b/highlevelilinstruction.h
@@ -196,7 +196,7 @@ namespace BinaryNinja
 #else
 			Ref<HighLevelILFunction> function;
 #endif
-			const uint64_t* cur;
+			size_t offset;
 			size_t count;
 
 			bool operator==(const ListIterator& a) const;