Fix a number of leaks and bad uses of free in the api

See https://github.com/Vector35/binaryninja-api/issues/4751

1 files changed, 6 insertions, 0 deletions

diff --git a/interaction.cpp b/interaction.cpp
index 037edca6..5b62084e 100644
--- a/interaction.cpp
+++ b/interaction.cpp
@@ -661,7 +661,10 @@ bool BinaryNinja::GetFormInput(vector<FormInputField>& fields, const string& tit
 
 	// If user cancelled, there are no results
 	if (!ok)
+	{
+		delete[] fieldBuf;
 		return false;
+	}
 
 	// Copy results to API structures
 	for (size_t i = 0; i < fields.size(); i++)
@@ -689,7 +692,10 @@ bool BinaryNinja::GetFormInput(vector<FormInputField>& fields, const string& tit
 		}
 	}
 
+	// Free core-allocated results
 	BNFreeFormInputResults(fieldBuf, fields.size());
+
+	delete[] fieldBuf;
 	return true;
 }