summaryrefslogtreecommitdiff
path: root/plugins/warp/ui/matched.cpp
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2025-10-12 22:48:41 -0400
committerMason Reed <mason@vector35.com>2025-10-12 22:50:20 -0400
commit253fd4ad2d8095cc3c640c99d75ab3fd1cb7282e (patch)
tree2bb2549d4aa29971143ec013df9cc6971abc6be2 /plugins/warp/ui/matched.cpp
parent40f7d40e394657575001a8146d8233f1fc4356fd (diff)
[WARP] Fix misc sidebar navigation / focus event bugs
- Fixed crash related to pending fetch callback for deleted view frame - Fixed focus not being kept for tables in the sidebar, as well as focus in general - Made matched function list navigation require a double click, to fix accidental navigation to other functions
Diffstat (limited to 'plugins/warp/ui/matched.cpp')
-rw-r--r--plugins/warp/ui/matched.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/plugins/warp/ui/matched.cpp b/plugins/warp/ui/matched.cpp
index 7112e74e..786b9d26 100644
--- a/plugins/warp/ui/matched.cpp
+++ b/plugins/warp/ui/matched.cpp
@@ -47,7 +47,7 @@ WarpMatchedWidget::WarpMatchedWidget(BinaryViewRef current)
Update();
- connect(m_tableWidget->GetTableView(), &QTableView::clicked, this, [this](const QModelIndex& index) {
+ connect(m_tableWidget->GetTableView(), &QTableView::doubleClicked, this, [this](const QModelIndex& index) {
if (m_current == nullptr)
return;
if (!index.isValid())
@@ -60,6 +60,7 @@ WarpMatchedWidget::WarpMatchedWidget(BinaryViewRef current)
return;
// Navigate to the address in the view, so the user feels like they are doing something.
auto currentView = m_current->GetCurrentView();
+ // TODO: Navigate unconditionally steals focus, need to figure out how to prevent the loss of focus.
m_current->Navigate(currentView, selectedItem.value());
});
}