diff options
| author | Mason Reed <mason@vector35.com> | 2025-11-20 18:01:48 -0500 |
|---|---|---|
| committer | Mason Reed <35282038+emesare@users.noreply.github.com> | 2025-11-25 22:29:25 -0500 |
| commit | cbd954c0d4c5718442b71e2b65fd5a731765c6d5 (patch) | |
| tree | e24e49d3a15b556e999ae3a6953fc670f69769cb /plugins/warp | |
| parent | 269a58437f9da2d46e7fd49712a555722436d6fb (diff) | |
[WARP] Fix leaking binary view on empty views
Can be triggered by trying to run the processor on a file with no functions.
Found this while doing misc performance testing on windows.
Diffstat (limited to 'plugins/warp')
| -rw-r--r-- | plugins/warp/src/processor.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/plugins/warp/src/processor.rs b/plugins/warp/src/processor.rs index 4f0372e6..2319c5fc 100644 --- a/plugins/warp/src/processor.rs +++ b/plugins/warp/src/processor.rs @@ -664,6 +664,8 @@ impl WarpFileProcessor { if view.functions().is_empty() { self.state .set_file_state(path.clone(), ProcessingFileState::Processed); + // Close the view manually, see comment in [`BinaryView`]. + view.file().close(); return Err(ProcessingError::SkippedFile(path)); } |
