summaryrefslogtreecommitdiff
path: root/plugins/workflow_objc/CONTRIBUTING.md
diff options
context:
space:
mode:
authorMark Rowe <mark@vector35.com>2025-08-11 10:42:07 -0700
committerMark Rowe <mark@vector35.com>2025-08-27 19:15:49 -0700
commit2303f75b080f6dd0c9a5c669a71f64ce830f5650 (patch)
treea49d80ea0a8131a50c16f85e767722679ff08c85 /plugins/workflow_objc/CONTRIBUTING.md
parentb302d7ba796f41b1102ee61feed8b8e212299997 (diff)
Rewrite Obj-C workflow in Rust
This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow.
Diffstat (limited to 'plugins/workflow_objc/CONTRIBUTING.md')
-rw-r--r--plugins/workflow_objc/CONTRIBUTING.md26
1 files changed, 0 insertions, 26 deletions
diff --git a/plugins/workflow_objc/CONTRIBUTING.md b/plugins/workflow_objc/CONTRIBUTING.md
deleted file mode 100644
index 77539dff..00000000
--- a/plugins/workflow_objc/CONTRIBUTING.md
+++ /dev/null
@@ -1,26 +0,0 @@
-# Contribution Guidelines
-
-Contributions in the form of issues and pull requests are welcome! See the
-sections below if you are contributing code.
-
-## Conventions
-
-Refer to the [WebKit Style Guide](https://webkit.org/code-style-guidelines/)
-when in doubt.
-
-## Formatting
-
-Let `clang-format` take care of it. The built-in WebKit style is used.
-
-```sh
-clang-format -i --style=WebKit <file>
-```
-
-- Split long lines when it improves readability. 80 columns is the preferred
-maximum line length, but use some judgement and don't split lines just because a
-semicolon exceeds the length limit, etc.
-
-## Testing
-
-If you are making changes to the core analysis library, run the test suite and
-ensure that there are no unexpected changes to analysis behavior.