diff options
| author | Mason Reed <mason@vector35.com> | 2025-04-10 16:39:26 -0400 |
|---|---|---|
| committer | Mason Reed <mason@vector35.com> | 2025-04-10 17:19:34 -0400 |
| commit | 1973b852a1ffc2ea3e050d078a6f2b9933c199a1 (patch) | |
| tree | 3f5fb2c328dd65ea2dff7b80de1b3e89d87d301e /plugins | |
| parent | 2c79a0458cd5bc7af0264d18d8ca2fc1a7894228 (diff) | |
Fix function type construction leaking in Rust API
Diffstat (limited to 'plugins')
| -rw-r--r-- | plugins/dwarf/dwarf_import/src/dwarfdebuginfo.rs | 2 | ||||
| -rw-r--r-- | plugins/idb_import/src/lib.rs | 2 | ||||
| -rw-r--r-- | plugins/pdb-ng/src/parser.rs | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/plugins/dwarf/dwarf_import/src/dwarfdebuginfo.rs b/plugins/dwarf/dwarf_import/src/dwarfdebuginfo.rs index 672bdf68..604867f5 100644 --- a/plugins/dwarf/dwarf_import/src/dwarfdebuginfo.rs +++ b/plugins/dwarf/dwarf_import/src/dwarfdebuginfo.rs @@ -581,7 +581,7 @@ impl DebugInfoBuilder { for function in self.functions() { // let calling_convention: Option<Ref<CallingConvention<CoreArchitecture>>> = None; - debug_info.add_function(DebugFunctionInfo::new( + debug_info.add_function(&DebugFunctionInfo::new( function.full_name.clone(), function.full_name.clone(), // TODO : This should eventually be changed, but the "full_name" should probably be the unsimplified version, and the "short_name" should be the simplified version...currently the symbols view shows the full version, so changing it here too makes it look bad in the UI function.raw_name.clone(), diff --git a/plugins/idb_import/src/lib.rs b/plugins/idb_import/src/lib.rs index 70bbf07c..c554831d 100644 --- a/plugins/idb_import/src/lib.rs +++ b/plugins/idb_import/src/lib.rs @@ -269,7 +269,7 @@ fn parse_id0_section_info( if bnty.is_none() { error!("Unable to convert the function type at {addr:#x}",) } - if !debug_info.add_function(DebugFunctionInfo::new( + if !debug_info.add_function(&DebugFunctionInfo::new( None, None, label.map(str::to_string), diff --git a/plugins/pdb-ng/src/parser.rs b/plugins/pdb-ng/src/parser.rs index 101b8868..783a8a2d 100644 --- a/plugins/pdb-ng/src/parser.rs +++ b/plugins/pdb-ng/src/parser.rs @@ -261,7 +261,7 @@ impl<'a, S: Source<'a> + 'a> PDBParserInstance<'a, S> { address, &name.raw_name, type_ ) }); - self.debug_info.add_function(DebugFunctionInfo::new( + self.debug_info.add_function(&DebugFunctionInfo::new( Some(name.short_name.unwrap_or(name.raw_name.clone())), Some(name.full_name.unwrap_or(name.raw_name.clone())), Some(name.raw_name), |