Better error handling for get_view_of_file_with_options.

1 files changed, 5 insertions, 3 deletions

diff --git a/python/binaryview.py b/python/binaryview.py
index 15838c0d..d54a0d07 100644
--- a/python/binaryview.py
+++ b/python/binaryview.py
@@ -837,11 +837,13 @@ class BinaryViewType(with_metaclass(_BinaryViewTypeMetaclass, object)):
 		view.set_load_settings(bvt.name, load_settings)
 		for key, value in options.items():
 			if load_settings.contains(key):
-				load_settings.set_json(key, json.dumps(value), view)
+				if not load_settings.set_json(key, json.dumps(value), view):
+					raise ValueError("Setting: {} set operation failed!".format(key))
 			elif default_settings.contains(key):
-				default_settings.set_json(key, json.dumps(value), view)
+				if not default_settings.set_json(key, json.dumps(value), view):
+					raise ValueError("Setting: {} set operation failed!".format(key))
 			else:
-				log.log_error("Setting: {} not available!".format(key))
+				raise NotImplementedError("Setting: {} not available!".format(key))
 
 		bv = bvt.create(view)