summaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorPeter LaFosse <peter@vector35.com>2021-09-28 09:36:45 -0400
committerPeter LaFosse <peter@vector35.com>2021-09-28 13:24:42 -0400
commit318cfccb60ae53f47b0f5636c06e6d58af89f568 (patch)
tree6d51b17b2171f9a8f8cc46f39e853e78a64e50d9 /python
parentb047323085a3b2c566471b76614fd6fc4594caba (diff)
Removed some commented code
Diffstat (limited to 'python')
-rw-r--r--python/binaryview.py2
-rw-r--r--python/types.py44
2 files changed, 3 insertions, 43 deletions
diff --git a/python/binaryview.py b/python/binaryview.py
index be57d330..cc3754a6 100644
--- a/python/binaryview.py
+++ b/python/binaryview.py
@@ -640,9 +640,9 @@ class _BinaryViewTypeMetaclass(type):
class BinaryViewType(metaclass=_BinaryViewTypeMetaclass):
+ # Used to force Python callback objects to not get garbage collected
_platform_recognizers = {}
def __init__(self, handle:core.BNBinaryViewTypeHandle):
- # Used to force Python callback objects to not get garbage collected
_handle = core.BNBinaryViewTypeHandle
self.handle = ctypes.cast(handle, _handle)
diff --git a/python/types.py b/python/types.py
index c5ce1924..33186904 100644
--- a/python/types.py
+++ b/python/types.py
@@ -920,11 +920,6 @@ class FunctionBuilder(TypeBuilder):
def variable_arguments(self) -> BoolWithConfidence:
return BoolWithConfidence.from_core_struct(core.BNTypeBuilderHasVariableArguments(self._handle))
- # TODO: implement core.BNSetFunctionTypeBuilderHasVariableArguments
- # @variable_arguments.setter
- # def variabale_arguments(self, value:BoolWithConfidenceType) -> None: # type: ignore
- # core.BNSetFunctionTypeBuilderHasVariableArguments(self_handle, BoolWithConfidence.get_core_struct(value))
-
@staticmethod
def _to_core_struct(params:ParamsType):
param_buf = (core.BNFunctionParameter * len(params))()
@@ -1135,40 +1130,6 @@ class StructureBuilder(TypeBuilder):
return index
- # def erase(self, index:MemberIndex=None, name:MemberName=None, offset:MemberOffset=None) -> None:
- # # removes the specified item shrinking the total size of the structure and adjusting
- # # the offset of any members with offsets greater than the offset of member[index].
- # # In the case where there are multiple members which overlap the erased item they will be erased too
- # # but the structure will only be shrunken by the specified member's width
- # # raise exception if the index doesn't exist
- # # raises exception if more not exactly one of index/name/offset are not None
- # item = self.members[self.index_from(index, name, offset)]
- # self.clear_members(item.offset, len(item))
- # self.adjust_space(item.offset, -len(item))
-
- # def clear(self, index:MemberIndex=None, name:MemberName=None, offset:MemberOffset=None) -> None:
- # # clears the member at the index/member-name. No adjustment is made to other members or the structure's size
- # # raise exception if the index doesn't exist
- # del self.members[self.index_from(index, name, offset)]
-
- # def clear_members(self, offset:MemberOffset, size:int) -> None:
- # # clears members which overlap offset
- # to_clear = []
- # for i, member in enumerate(self.members):
- # if member.offset >= offset and member.offset < offset + size:
- # to_clear.append(i)
- # elif member.offset < offset and member.offset + len(member) > offset:
- # to_clear.append(i)
- # for i in to_clear:
- # self.clear(index=i)
-
- # def replace_member(self, new_name:MemberName, type:SomeType, index:MemberIndex=None, old_name:MemberName=None, offset:MemberOffset=None) -> None:
- # # replaces any members within the structure which overlap member[index]
- # index = self.index_from(index, old_name, offset)
- # item = self.members[index]
- # self.clear_members(item.offset, len(item))
- # self.members.insert(index, StructureMember(type, new_name, item.offset))
-
def replace(self, index:int, type:SomeType, name:str="", overwrite_existing:bool=True):
core.BNReplaceStructureBuilderMember(self.builder_handle, index,
type._to_core_struct(), name, overwrite_existing)
@@ -1928,9 +1889,8 @@ class StructureType(Type):
if core is not None:
core.BNFreeStructure(self.struct_handle)
- # TODO: Commented to pass unit tests
- # def __repr__(self):
- # return f"<struct: {self.registered_name}>"
+ def __repr__(self):
+ return f"<struct: {self.registered_name}>"
def __eq__(self, other):
if not isinstance(other, self.__class__):