summaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorBrian Potchik <brian@vector35.com>2020-04-08 01:07:03 -0400
committerBrian Potchik <brian@vector35.com>2020-04-08 01:07:03 -0400
commitc8daa31c9029104a8d07cb37a1537bb8b8f66558 (patch)
treea0a6c5d807d0270d92748c485ea87bf31682cb99 /python
parent8c550f9ee9a5fcb5ec5f2cff3f0aa1e7bb68a709 (diff)
Allow get_view_of_file_with_options to set default settings in addition to load settings.
Diffstat (limited to 'python')
-rw-r--r--python/binaryview.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/python/binaryview.py b/python/binaryview.py
index 80c3a5b9..15838c0d 100644
--- a/python/binaryview.py
+++ b/python/binaryview.py
@@ -830,14 +830,18 @@ class BinaryViewType(with_metaclass(_BinaryViewTypeMetaclass, object)):
if bvt is None:
bvt = cls["Mapped"]
+ default_settings = settings.Settings()
+ default_settings.set_resource_id(bvt.name)
load_settings = bvt.get_load_settings_for_data(view)
load_settings.set_resource_id(bvt.name)
view.set_load_settings(bvt.name, load_settings)
for key, value in options.items():
if load_settings.contains(key):
load_settings.set_json(key, json.dumps(value), view)
+ elif default_settings.contains(key):
+ default_settings.set_json(key, json.dumps(value), view)
else:
- log.log_warn("Load Setting: {} not available!".format(key))
+ log.log_error("Setting: {} not available!".format(key))
bv = bvt.create(view)