summaryrefslogtreecommitdiff
path: root/rust/src/binaryview.rs
diff options
context:
space:
mode:
authorKyle Martin <krm504@nyu.edu>2024-05-15 13:31:21 -0400
committerKyle Martin <krm504@nyu.edu>2024-05-15 13:33:50 -0400
commit3037596e9489f75929454cda082bedbd163d9129 (patch)
tree9fdb1206087d684d3ebcf008de3d25251f2f95b4 /rust/src/binaryview.rs
parentdfd0109db25a3d2a63277ac3bbc848474d71ae53 (diff)
Apply suggestions from code review
Co-authored-by: Michael Krasnitski <42564254+mkrasnitski@users.noreply.github.com>
Diffstat (limited to 'rust/src/binaryview.rs')
-rw-r--r--rust/src/binaryview.rs6
1 files changed, 2 insertions, 4 deletions
diff --git a/rust/src/binaryview.rs b/rust/src/binaryview.rs
index 120a41c9..33be62d9 100644
--- a/rust/src/binaryview.rs
+++ b/rust/src/binaryview.rs
@@ -227,8 +227,7 @@ pub trait BinaryViewExt: BinaryViewBase {
fn read_vec(&self, offset: u64, len: usize) -> Vec<u8> {
let mut ret = vec![0; len];
- let slice = ret.as_mut_slice();
- let size = self.read(slice, offset);
+ let size = self.read(&mut ret, offset);
ret.truncate(size);
ret
@@ -238,8 +237,7 @@ pub trait BinaryViewExt: BinaryViewBase {
fn read_into_vec(&self, dest: &mut Vec<u8>, offset: u64, len: usize) -> usize {
let starting_len = dest.len();
dest.resize(starting_len + len, 0);
- let slice = &mut dest[starting_len..];
- let read_size = self.read(slice, offset);
+ let read_size = self.read(&mut dest[starting_len..], offset);
dest.truncate(starting_len + read_size);
read_size
}