diff options
| author | Mason Reed <mason@vector35.com> | 2025-02-02 19:34:27 -0500 |
|---|---|---|
| committer | Mason Reed <mason@vector35.com> | 2025-02-13 13:00:05 -0500 |
| commit | ee5063327e3ddefaa59ee2ff90e6e9f54eca2076 (patch) | |
| tree | 15fd185a398de6a08832839cd78f1fbe5393b86a /rust/src/debuginfo.rs | |
| parent | 1014cb1872c06b7dbfbee55d4a0b4e6a5743ec6b (diff) | |
Fix leaking BNDataVariableAndName when calling BNGetDebugDataVariableBy functions
Diffstat (limited to 'rust/src/debuginfo.rs')
| -rw-r--r-- | rust/src/debuginfo.rs | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/rust/src/debuginfo.rs b/rust/src/debuginfo.rs index 72d5fdab..11d5f249 100644 --- a/rust/src/debuginfo.rs +++ b/rust/src/debuginfo.rs @@ -562,18 +562,18 @@ impl DebugInfo { ) -> Option<NamedDataVariableWithType> { let parser_name = parser_name.into_bytes_with_nul(); let name = name.into_bytes_with_nul(); - let raw_named_var = unsafe { - BNGetDebugDataVariableByName( + let mut dv = BNDataVariableAndName::default(); + unsafe { + if BNGetDebugDataVariableByName( self.handle, parser_name.as_ref().as_ptr() as *mut _, name.as_ref().as_ptr() as *mut _, - ) - }; - - if !raw_named_var.is_null() { - Some(unsafe { NamedDataVariableWithType::from_ref_raw(raw_named_var) }) - } else { - None + &mut dv, + ) { + Some(NamedDataVariableWithType::from_owned_raw(dv)) + } else { + None + } } } @@ -583,18 +583,18 @@ impl DebugInfo { address: u64, ) -> Option<NamedDataVariableWithType> { let parser_name = parser_name.into_bytes_with_nul(); - let raw_named_var = unsafe { - BNGetDebugDataVariableByAddress( + let mut dv = BNDataVariableAndName::default(); + unsafe { + if BNGetDebugDataVariableByAddress( self.handle, parser_name.as_ref().as_ptr() as *mut _, address, - ) - }; - - if !raw_named_var.is_null() { - Some(unsafe { NamedDataVariableWithType::from_ref_raw(raw_named_var) }) - } else { - None + &mut dv, + ) { + Some(NamedDataVariableWithType::from_owned_raw(dv)) + } else { + None + } } } |
