Rust refactor

Moves a bunch of stuff out of src/types.rs that did not belong:
- Confidence
- Variable
- Function specific stuff

- Refactored InstructionInfo, see the msp430 and riscv examples.
- Renamed Function::from_raw to Function::ref_from_raw and fixed places where the ref was incremented twice
- Fixed FunctionRecognizer leaking functions (see above)
- Fixed some apis incorrectly returning Result where Option is clearer
- Started to move destructured types to the From trait for converting to an from ffi types, see Location for an example
- Started to remove bad module level imports (importing std modules like mem all over the place)
- Moved some wrapper handle types to named handle field (this improves readability), see CoreArchitecture for an example
- Removed some unintuitive getters, this is bad practice for Rust code, just access the field directly, see DataVariable for an example
- General code cleanup, purposely did not run rustfmt, that will be a single seperate commit

More rust cleanup

- Fixed invalid views being able to invoke UB when dealing with databases
- Cleaned up some helper code in dwarf_import
- Fixed inverted is_null checks causing crashes! Oops!

More rust cleanup

Still a WIP, I think branch info is still invalid, need to figure out the issue there.

- Fixed some invalid Ref lifetimes when constructing indirectly, see Array<DataVariable> for example
- Added some more comments
- Removed some "magic" functions like MLIL Function::ssa_variables

There are still a bunch of invalid lifetimes that aren't crashing us due to the usage of those API's not living long enough. But they ARE an issue.

More rust cleanup

Trying to comment more TODO's as I go along.

- Renamed llil::Function to llil::LowLevelILFunction for clarity and consistency
- Take base structures by ref in StructureBuilder::set_base_structures to prevent premature drops
- Added more raw to wrapper conversions
- Removed UB prone apis
- Getting rid of more core module references, use std!
- Removed improper Guard usage in array impls for wrapper types with no context
- Untangling the UB of the Label api, still only half done :/

More rust cleanup

- Misc formatting
- Made Logger ref counted
- Fixed leaking name of logger every time something was logged
- Fixed the last (hopefully) of the unresolved labels
- Simplified some code

Fix leak in DebugInfo::AddType

componentArray was never freed

Add more HLIL related functions to rust

More rust cleanup

improve the CustomBinaryView init process

Canonicalize path in `create_delete_empty` test

Link core in rust

When linking you must depend on the -sys crate.

This is because linker arguments (what says where to find binaryninjacore) are NOT transitive. The top level application crate MUST provide it.

For more information see:
- https://github.com/rust-lang/cargo/issues/9554#issuecomment-857882964
- https://github.com/oxidecomputer/omicron/pull/225

Remove vendored pdb crate

Use cargo to manage the git repo ref instead

Fix misc rustdoc warnings

Move actual plugins out of `rust/examples` and into `plugins`

This is where all shipped public plugins that are not arch/view/platform/lang will be at from now on

Originally they were in the rust workspace, meaning they all shared a Cargo.lock which is ill-advised.

More rust cleanup

- More clarification on plugin/executable requirements
- Made examples actually rust examples
- Add Display impl for InstructionTextToken
- Renamed feature "noexports" to "no_exports"

Move under_construction.png to assets directory

This really did bother me

Remove unneeded `extern crate bindgen`

Replace nop'd log::info with println

We don't register a compatible log sink so they will just get sent into the void

Move inline tests into tests directory

This is being done in the hopes of curbing the multi-thousand line files that will occur once we flesh out the tests

Format rust code

Update rust ci

Still need to add support for running tests in ci

More rust cleanup

- Architecture id's are now typed accordingly
- Fix some clippy lints
- Make instruction index public in LLIL
- Removed useless helper functions
- LLIL expressions and instruction indexes are now typed accordingly

Generate binaryninjacore-sys documentation

This should show binaryninjacore-sys alongside binaryninja crate

More rust cleanup

- Remove lazy_static dependency
- Remove hacky impl Debug for Type and just use the display impl
- Add more debug impls
- Reorder some top level namespace items
- Add first type test

Remove unneeded script helper in rust api

More rust cleanup

- Added main thread handler api
- Register a headless main thread handler by default in initialization
- Refactor QualifiedName to be properly owned
- Loosened some type constraints on some apis involving QualifiedName
- Fixed some apis that were crashing due to incorrect param types
- Removed extern crate cruft for log crate
- Simplified headless initialization using more wrapper apis
- Fixed segments leaking because of no ref wrapper, see BinaryViewExt::segment_at
- Added rstest to manage headless init in unit tests
- Added some more unit tests
- Refactored demangler api to be more ergonomic
- Fixed minidump plugin not building

More rust cleanup

- Fixup usage of QualifiedName in plugins
- Make QualifiedName more usable

Implement rust TypeParser

fix Platform TypeParser related functions

separate User and System implementations of TypeParserResult

Implement rust TypeContainer

More rust cleanup

- Hopefully fixed the rust.yml CI
- Added TypePrinter API (this is still WIP and will crash)
- Added TypeParser API
- Added TypeContainer API
- More work around QualifiedName apis

Oh your suppose to do this

Add workflow_dispatch trigger to rust.yml

More rust fixes

- Swapped some usage of raw 255 to MAX_CONFIDENCE, no one likes magic numbers
- New InstructionTextToken API, complete with owned data, this still needs a lot of testing.
- InstructionTextTokenKind describes a destructured InstructionTextToken, this should make token usage much clearer, some docs pending
- Added some misc Default and Debug impls
- Updated TypePrinter and architectures to use new InstructionTextToken API

Misc formatting changes

More rust cleanup

- Fixed MANY memory leaks (most due to QualifiedName)
- Made StructureBuilder more builder and less structure
- Fixed CMakeLists.txt that were globbing entire api, resulting in 100 second slowdown on cmake generation
- Added more Debug impl's
- Added some more tests
- Fixed TypeParserResult UB
- Moved the From impls to blank impl for clarity, we have multiple different variants of core to rust for some structures, it should be explicit which one you are choosing.
- PossibleValueSet should now be able to allocate so we can go from rust to core with those variants that require allocation
- Misc doc code formatting

Misc clippy lints and clippy CI

Co-authored-by: Michael Krasnitski <michael.krasnitski@gmail.com>

Fix typo in rust CI

Misc rust formatting

Fix misc typos and add typos to rust CI

Add cargo workspace

This will help tooling and external contributors get a map of the rust crates within binaryninja-api

More rust cleanup

- Format all rust plugins
- Fix some tests that were out of date
- Simplify WARP tests to only binaries, building object files from source is a pain
- Link to core in all rust plugins
- Fix some memory leaks
- Update warp insta snapshots
- Fix some misc clippy lints

Run rust tests in CI

This commit also coincides with the creation of the "testing" environment which exposes a BN_SERIAL secret for pulling a headless Binary Ninja

Install missing wayland dependency in github CI

Apparently its needed for linux file picker for the WARP integration

Set the BINARYNINJADIR so rust can find binaryninjacore in CI

The chances of this working are low

Misc remove unused dependency

Rust misc formatting fixes

Improve initialization in rust headless scripts

Provide sensible errors and validation to rust headless scripts, solves https://github.com/Vector35/binaryninja-api/issues/5796

Add BN_LICENSE environment variable to rust CI

We pass the serial to download binary ninja, but we never provided the license for core initialization

Fix typo

More rust cleanup

- Improved binary view initialization (see init_with_opts)
- Allow floating license to free itself before initialization
- Add initialization unit test
- Add better Debug impls for some common types
- Use Path api for opening binary views, this is not breaking as it uses the AsRef impl
- Bump rayon dependency and constrain dependencies to x.x

Update readme and include that directly in the rustdocs

More rust documentation changes

Add format comment to InitializationOptions::with_license

Misc formatting and clippy lint allow

More rust cleanup

- Remove under_construction.png from the build.rs it has been removed
- Use InstructionIndex in more places
- Add missing PartialOrd and Ord impls for id types

More rust cleanup

- Make workflow cloning explicit
- Add workflow tests
- Add missing property string list getting for settings
- Remove IntoActivityName (see https://github.com/Vector35/binaryninja-api/pull/6257)

More rust cleanup

This commit is half done

Misc rust formatting

More rust cleanup

- Renamed common name conflictions (I will put my justification in the PR)
- Fixed invalid instruction retrieval for LLIL
- Added common aliases for llil function, instruction and expression types (see my comment in the PR)
- Refactored the instruction retrieval for LLIL, MLIL and HLIL
- Added instruction index types to MLIL and HLIL
- Moved llil module to lowlevelil module (mlil and hlil will be moved as well)
- Added preliminary LLIL unit testing

Fix typos

Misc clippy fixes

More rust cleanup

- Normalized modules
- Split some code out into own files
- Fixed some UB in type archive and projects
- Improved API around type archives and projects substantially
- Added ProgressExecutor abstraction for functions which have a progress callback
- Improved background task documentation and added unit tests
- Added worker thread api and unit tests
- Moved some owned types to ref types, this is still not complete, but this is the path forward.
- Add external location/library accessors to the binary view
- Added some misc documentation
- Replaced mod.rs with the module name source file

Still need to normalize some paths and also update some documentation surrounding that change.

Update some tests and examples

Fix background task tests colliding

We were creating multiple background tasks with the same progress text on multiple threads

More rust cleanup

- Fixed progress executor freeing itself after one iteration
- Updated the last of the doc imports
- Moved mainthread to main_thread
- Made project creation and opening failable

We could probably AsRef<ProgressExecutor> to get around the allocation and free inside the function bodies, not high priority as those functions are long running anyways.

Move binary view initialization into function body for LLIL test

Normalize test file names

More rust cleanup

- Updated README to clarify offline documentation
- Refactored settings api
- Added settings example to show dumping settings value and specific properties
- Use the workspace to depend on binaryninja and binaryninjacore-sys
- Remove binaryninjacore-sys as a workspace member (its not really required)

Update workflow test to new settings api

More rust cleanup

- Rename Label to LowLevelILLabel
- Update the functions label map automatically

This fixed a major api blunder where the label map is returned as a reference and originally resulted in UB prone lifetime semantics. It was temporarily "fixed" with explicit label updates in the architecture implementation code. But that was less than ideal and was easy to mess up. Now the label map will be updated automatically as the location of labels is now tracked.

Misc clippy lints

More rust cleanup

- Get rid of RawFunctionViewType
- Add better Debug impl for Function

More rust cleanup

- Fixed the documentation icon using local files (thank you @mkrasnitski)
- Fixed labels being updated and overwriting the label location used to update the label map

More rust cleanup

- Added unit tests for MLIL and HLIL
- "Fixed" MLIL, LLIL, and HLIL having issues regarding Instruction vs Expression indexes
- Renamed CallingConvention to CoreCallingConvention and removed architecture generic
- Renamed CallingConventionBase to CallingConvention
- Simplified calling convention code and fixed some bugs with implicit registers
- Added impl Debug to MLIL and HLIL instructions

Still need to at some point add an Expression to MLIL and HLIL. We also might want to look into having the Instruction kind just return the expression kind.

Misc clippy lint

More rust cleanup

- Allow calling conventions to be registered for multiple architectures
- Swapped a unreachable statement to an unimplemented statement

More rust cleanup

- Fixed the issue with PDB types, this has caused me an insane amount of grief
- Fixed LLIL visit_tree missing LLIL_LOAD expressions
- Added LLIL visitor test
- Made all WARP file pickers use the rfd crate

Use the dev branch of Binary Ninja in rust CI

Misc rust fmt

More rust cleanup

- Refactored BinaryReader and BinaryWriter
- Added some warnings to high_level_il and medium_level_il modules that they are unstable
- Add BinaryReader and BinaryWriter tests
- Changed BinaryView len to return u64 (that is what the core returns)
- Misc formatting changes
- Remove extern uses in lib.rs

Add impl Debug for BinaryReader and BinaryWriter

Turn off broken tests

Add more info to the rust README.md

More rust cleanup

- Make EdgeStyle type not wrap raw
- Regression tests for WARP will run on all bins in the out dir now

impl rust Collaboration and Remote API

Fix typo

Update collaboration API

Makes collaboration more in line with the refactor. Still a lot of work to do.

Namely still need:
- Proper errors
- _with_opts functions
- More ergonomic api
- Better connection procedure
- Updated documentation
- A LOT of unit tests
- An example
- Typed id's for everything (i dont want BnString as the id!!!)
- NEED to refactor the progress callbacks into the new progress api, but we should pull in some of the stuff the collab progress has
- Elimination of apis that are dumb helpers

Separate out the rust testing and use pull_request_target

pull_request_target allows PR's to access the headless license, for this to be safe we need to prevent people from running the job.

To prevent the job from being ran we add an environment requirement on testing that a reviewer must review the code and then manually approve it to run.

More rust cleanup

- Use GroupId instead of u64
- Use ProgressCallback in place of ProgressExecutor
- Misc cleanup of FileMetadata
- Add `save_to_path` and `save_to_accessor` to save modified binaries
- Added binary_view unit tests
- Added collaboration unit tests
- Fixed a few issues with the collaboration apis
- Renamed Command registration functions so that there is no import ambiguity
- Split out RemoteUndoEntry
- Collaboration apis now have a explicit `_with_progress` set of apis
- Misc clippy lint fixes

Fix some typos

More rust cleanup

- Add extra info to README.md
- Refactor components api
- Add components unit test

Add testing and documentation to contributing section in README.md

Fix misc doc comments

1 files changed, 0 insertions, 825 deletions

diff --git a/rust/src/llil/operation.rs b/rust/src/llil/operation.rs
deleted file mode 100644
index b65dfa8c..00000000
--- a/rust/src/llil/operation.rs
+++ /dev/null
@@ -1,825 +0,0 @@
-// Copyright 2021-2024 Vector 35 Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-use binaryninjacore_sys::{BNGetLowLevelILByIndex, BNLowLevelILInstruction};
-
-use std::collections::BTreeMap;
-use std::marker::PhantomData;
-use std::mem;
-
-use super::*;
-
-pub struct Operation<'func, A, M, F, O>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-    O: OperationArguments,
-{
-    pub(crate) function: &'func Function<A, M, F>,
-    pub(crate) op: BNLowLevelILInstruction,
-    _args: PhantomData<O>,
-}
-
-impl<'func, A, M, F, O> Operation<'func, A, M, F, O>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-    O: OperationArguments,
-{
-    pub(crate) fn new(function: &'func Function<A, M, F>, op: BNLowLevelILInstruction) -> Self {
-        Self {
-            function,
-            op,
-            _args: PhantomData,
-        }
-    }
-
-    pub fn address(&self) -> u64 {
-        self.op.address
-    }
-}
-
-impl<'func, A, M, O> Operation<'func, A, M, NonSSA<LiftedNonSSA>, O>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    O: OperationArguments,
-{
-    pub fn flag_write(&self) -> Option<A::FlagWrite> {
-        match self.op.flags {
-            0 => None,
-            id => self.function.arch().flag_write_from_id(id),
-        }
-    }
-}
-
-// LLIL_NOP, LLIL_NORET, LLIL_BP, LLIL_UNDEF, LLIL_UNIMPL
-pub struct NoArgs;
-
-// LLIL_POP
-pub struct Pop;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Pop>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-}
-
-// LLIL_SYSCALL, LLIL_SYSCALL_SSA
-pub struct Syscall;
-
-// LLIL_INTRINSIC, LLIL_INTRINSIC_SSA
-pub struct Intrinsic;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, Intrinsic>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    // TODO: Support register and expression lists
-    pub fn intrinsic(&self) -> Option<A::Intrinsic> {
-        let raw_id = self.op.operands[2] as u32;
-        self.function.arch().intrinsic_from_id(raw_id)
-    }
-}
-
-// LLIL_SET_REG, LLIL_SET_REG_SSA, LLIL_SET_REG_PARTIAL_SSA
-pub struct SetReg;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, SetReg>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn dest_reg(&self) -> Register<A::Register> {
-        let raw_id = self.op.operands[0] as u32;
-
-        if raw_id >= 0x8000_0000 {
-            Register::Temp(raw_id & 0x7fff_ffff)
-        } else {
-            self.function
-                .arch()
-                .register_from_id(raw_id)
-                .map(Register::ArchReg)
-                .unwrap_or_else(|| {
-                    error!(
-                        "got garbage register from LLIL_SET_REG @ 0x{:x}",
-                        self.op.address
-                    );
-
-                    Register::Temp(0)
-                })
-        }
-    }
-
-    pub fn source_expr(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-}
-
-// LLIL_SET_REG_SPLIT, LLIL_SET_REG_SPLIT_SSA
-pub struct SetRegSplit;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, SetRegSplit>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn dest_reg_high(&self) -> Register<A::Register> {
-        let raw_id = self.op.operands[0] as u32;
-
-        if raw_id >= 0x8000_0000 {
-            Register::Temp(raw_id & 0x7fff_ffff)
-        } else {
-            self.function
-                .arch()
-                .register_from_id(raw_id)
-                .map(Register::ArchReg)
-                .unwrap_or_else(|| {
-                    error!(
-                        "got garbage register from LLIL_SET_REG_SPLIT @ 0x{:x}",
-                        self.op.address
-                    );
-
-                    Register::Temp(0)
-                })
-        }
-    }
-
-    pub fn dest_reg_low(&self) -> Register<A::Register> {
-        let raw_id = self.op.operands[1] as u32;
-
-        if raw_id >= 0x8000_0000 {
-            Register::Temp(raw_id & 0x7fff_ffff)
-        } else {
-            self.function
-                .arch()
-                .register_from_id(raw_id)
-                .map(Register::ArchReg)
-                .unwrap_or_else(|| {
-                    error!(
-                        "got garbage register from LLIL_SET_REG_SPLIT @ 0x{:x}",
-                        self.op.address
-                    );
-
-                    Register::Temp(0)
-                })
-        }
-    }
-
-    pub fn source_expr(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[2] as usize)
-    }
-}
-
-// LLIL_SET_FLAG, LLIL_SET_FLAG_SSA
-pub struct SetFlag;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, SetFlag>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn source_expr(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-}
-
-// LLIL_LOAD, LLIL_LOAD_SSA
-pub struct Load;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, Load>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn source_mem_expr(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-}
-
-// LLIL_STORE, LLIL_STORE_SSA
-pub struct Store;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, Store>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn dest_mem_expr(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn source_expr(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-}
-
-// LLIL_REG, LLIL_REG_SSA, LLIL_REG_SSA_PARTIAL
-pub struct Reg;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, Reg>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn source_reg(&self) -> Register<A::Register> {
-        let raw_id = self.op.operands[0] as u32;
-
-        if raw_id >= 0x8000_0000 {
-            Register::Temp(raw_id & 0x7fff_ffff)
-        } else {
-            self.function
-                .arch()
-                .register_from_id(raw_id)
-                .map(Register::ArchReg)
-                .unwrap_or_else(|| {
-                    error!(
-                        "got garbage register from LLIL_REG @ 0x{:x}",
-                        self.op.address
-                    );
-
-                    Register::Temp(0)
-                })
-        }
-    }
-}
-
-// LLIL_REG_SPLIT
-pub struct RegSplit;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, RegSplit>
-    where
-        A: 'func + Architecture,
-        M: FunctionMutability,
-        V: NonSSAVariant,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn low_reg(&self) -> Register<A::Register> {
-        let raw_id = self.op.operands[0] as u32;
-
-        if raw_id >= 0x8000_0000 {
-            Register::Temp(raw_id & 0x7fff_ffff)
-        } else {
-            self.function
-                .arch()
-                .register_from_id(raw_id)
-                .map(Register::ArchReg)
-                .unwrap_or_else(|| {
-                    error!(
-                        "got garbage register from LLIL_REG @ 0x{:x}",
-                        self.op.address
-                    );
-
-                    Register::Temp(0)
-                })
-        }
-    }
-
-    pub fn high_reg(&self) -> Register<A::Register> {
-        let raw_id = self.op.operands[1] as u32;
-
-        if raw_id >= 0x8000_0000 {
-            Register::Temp(raw_id & 0x7fff_ffff)
-        } else {
-            self.function
-                .arch()
-                .register_from_id(raw_id)
-                .map(Register::ArchReg)
-                .unwrap_or_else(|| {
-                    error!(
-                        "got garbage register from LLIL_REG @ 0x{:x}",
-                        self.op.address
-                    );
-
-                    Register::Temp(0)
-                })
-        }
-    }
-}
-
-// LLIL_FLAG, LLIL_FLAG_SSA
-pub struct Flag;
-
-// LLIL_FLAG_BIT, LLIL_FLAG_BIT_SSA
-pub struct FlagBit;
-
-// LLIL_JUMP
-pub struct Jump;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Jump>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn target(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-}
-
-// LLIL_JUMP_TO
-pub struct JumpTo;
-
-struct TargetListIter<'func, A, M, F>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    function: &'func Function<A, M, F>,
-    cursor: BNLowLevelILInstruction,
-    cursor_operand: usize,
-}
-
-impl<'func, A, M, F> TargetListIter<'func, A, M, F>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    fn next(&mut self) -> u64 {
-        if self.cursor_operand >= 3 {
-            self.cursor = unsafe {
-                BNGetLowLevelILByIndex(self.function.handle, self.cursor.operands[3] as usize)
-            };
-            self.cursor_operand = 0;
-        }
-        let result = self.cursor.operands[self.cursor_operand];
-        self.cursor_operand += 1;
-        result
-    }
-}
-
-impl<'func, A, M, F> Operation<'func, A, M, F, JumpTo>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn target(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn target_list(&self) -> BTreeMap<u64, usize> {
-        let mut result = BTreeMap::new();
-        let count = self.op.operands[1] as usize / 2;
-        let mut list = TargetListIter {
-            function: self.function,
-            cursor: unsafe {
-                BNGetLowLevelILByIndex(self.function.handle, self.op.operands[2] as usize)
-            },
-            cursor_operand: 0,
-        };
-
-        for _ in 0..count {
-            let value = list.next();
-            let target = list.next() as usize;
-            result.insert(value, target);
-        }
-
-        result
-    }
-}
-
-// LLIL_CALL, LLIL_CALL_SSA
-pub struct Call;
-
-impl<'func, A, M, V> Operation<'func, A, M, NonSSA<V>, Call>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    V: NonSSAVariant,
-{
-    pub fn target(&self) -> Expression<'func, A, M, NonSSA<V>, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn stack_adjust(&self) -> Option<u64> {
-        use binaryninjacore_sys::BNLowLevelILOperation::LLIL_CALL_STACK_ADJUST;
-
-        if self.op.operation == LLIL_CALL_STACK_ADJUST {
-            Some(self.op.operands[1])
-        } else {
-            None
-        }
-    }
-}
-
-// LLIL_RET
-pub struct Ret;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Ret>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn target(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-}
-
-// LLIL_IF
-pub struct If;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, If>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn condition(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn true_target(&self) -> Instruction<'func, A, M, F> {
-        Instruction {
-            function: self.function,
-            instr_idx: self.op.operands[1] as usize,
-        }
-    }
-
-    pub fn true_target_idx(&self) -> usize {
-        self.op.operands[1] as usize
-    }
-
-    pub fn false_target(&self) -> Instruction<'func, A, M, F> {
-        Instruction {
-            function: self.function,
-            instr_idx: self.op.operands[2] as usize,
-        }
-    }
-
-    pub fn false_target_idx(&self) -> usize {
-        self.op.operands[2] as usize
-    }
-}
-
-// LLIL_GOTO
-pub struct Goto;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Goto>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn target(&self) -> Instruction<'func, A, M, F> {
-        Instruction {
-            function: self.function,
-            instr_idx: self.op.operands[0] as usize,
-        }
-    }
-
-    pub fn target_idx(&self) -> usize {
-        self.op.operands[0] as usize
-    }
-}
-
-// LLIL_FLAG_COND
-pub struct FlagCond;
-
-// LLIL_FLAG_GROUP
-pub struct FlagGroup;
-
-impl<'func, A, M> Operation<'func, A, M, NonSSA<LiftedNonSSA>, FlagGroup>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-{
-    pub fn flag_group(&self) -> A::FlagGroup {
-        let id = self.op.operands[0] as u32;
-        self.function.arch().flag_group_from_id(id).unwrap()
-    }
-}
-
-// LLIL_TRAP
-pub struct Trap;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Trap>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn vector(&self) -> u64 {
-        self.op.operands[0]
-    }
-}
-
-// LLIL_REG_PHI
-pub struct RegPhi;
-
-// LLIL_FLAG_PHI
-pub struct FlagPhi;
-
-// LLIL_MEM_PHI
-pub struct MemPhi;
-
-// LLIL_CONST, LLIL_CONST_PTR
-pub struct Const;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Const>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn value(&self) -> u64 {
-        #[cfg(debug_assertions)]
-        {
-            let raw = self.op.operands[0] as i64;
-
-            let is_safe = match raw.overflowing_shr(self.op.size as u32 * 8) {
-                (_, true) => true,
-                (res, false) => [-1, 0].contains(&res),
-            };
-
-            if !is_safe {
-                error!(
-                    "il expr @ {:x} contains constant 0x{:x} as {} byte value (doesn't fit!)",
-                    self.op.address, self.op.operands[0], self.op.size
-                );
-            }
-        }
-
-        let mut mask = -1i64 as u64;
-
-        if self.op.size < mem::size_of::<u64>() {
-            mask <<= self.op.size * 8;
-            mask = !mask;
-        }
-
-        self.op.operands[0] & mask
-    }
-}
-
-// LLIL_EXTERN_PTR
-pub struct Extern;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Extern>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn value(&self) -> u64 {
-        #[cfg(debug_assertions)]
-        {
-            let raw = self.op.operands[0] as i64;
-
-            let is_safe = match raw.overflowing_shr(self.op.size as u32 * 8) {
-                (_, true) => true,
-                (res, false) => [-1, 0].contains(&res),
-            };
-
-            if !is_safe {
-                error!(
-                    "il expr @ {:x} contains extern 0x{:x} as {} byte value (doesn't fit!)",
-                    self.op.address, self.op.operands[0], self.op.size
-                );
-            }
-        }
-
-        let mut mask = -1i64 as u64;
-
-        if self.op.size < mem::size_of::<u64>() {
-            mask <<= self.op.size * 8;
-            mask = !mask;
-        }
-
-        self.op.operands[0] & mask
-    }
-}
-
-// LLIL_ADD, LLIL_SUB, LLIL_AND, LLIL_OR
-// LLIL_XOR, LLIL_LSL, LLIL_LSR, LLIL_ASR
-// LLIL_ROL, LLIL_ROR, LLIL_MUL, LLIL_MULU_DP,
-// LLIL_MULS_DP, LLIL_DIVU, LLIL_DIVS, LLIL_MODU,
-// LLIL_MODS
-pub struct BinaryOp;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, BinaryOp>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn left(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn right(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-}
-
-// LLIL_ADC, LLIL_SBB, LLIL_RLC, LLIL_RRC
-pub struct BinaryOpCarry;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, BinaryOpCarry>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn left(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn right(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-
-    pub fn carry(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[2] as usize)
-    }
-}
-
-// LLIL_DIVS_DP, LLIL_DIVU_DP, LLIL_MODU_DP, LLIL_MODS_DP
-pub struct DoublePrecDivOp;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, DoublePrecDivOp>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn high(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn low(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-
-    pub fn right(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[2] as usize)
-    }
-}
-
-// LLIL_PUSH, LLIL_NEG, LLIL_NOT, LLIL_SX,
-// LLIL_ZX, LLIL_LOW_PART, LLIL_BOOL_TO_INT, LLIL_UNIMPL_MEM
-pub struct UnaryOp;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, UnaryOp>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn operand(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-}
-
-// LLIL_CMP_X
-pub struct Condition;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, Condition>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn left(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-
-    pub fn right(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[1] as usize)
-    }
-}
-
-// LLIL_UNIMPL_MEM
-pub struct UnimplMem;
-
-impl<'func, A, M, F> Operation<'func, A, M, F, UnimplMem>
-where
-    A: 'func + Architecture,
-    M: FunctionMutability,
-    F: FunctionForm,
-{
-    pub fn size(&self) -> usize {
-        self.op.size
-    }
-
-    pub fn mem_expr(&self) -> Expression<'func, A, M, F, ValueExpr> {
-        Expression::new(self.function, self.op.operands[0] as usize)
-    }
-}
-
-// TODO TEST_BIT
-
-pub trait OperationArguments: 'static {}
-
-impl OperationArguments for NoArgs {}
-impl OperationArguments for Pop {}
-impl OperationArguments for Syscall {}
-impl OperationArguments for Intrinsic {}
-impl OperationArguments for SetReg {}
-impl OperationArguments for SetRegSplit {}
-impl OperationArguments for SetFlag {}
-impl OperationArguments for Load {}
-impl OperationArguments for Store {}
-impl OperationArguments for Reg {}
-impl OperationArguments for RegSplit {}
-impl OperationArguments for Flag {}
-impl OperationArguments for FlagBit {}
-impl OperationArguments for Jump {}
-impl OperationArguments for JumpTo {}
-impl OperationArguments for Call {}
-impl OperationArguments for Ret {}
-impl OperationArguments for If {}
-impl OperationArguments for Goto {}
-impl OperationArguments for FlagCond {}
-impl OperationArguments for FlagGroup {}
-impl OperationArguments for Trap {}
-impl OperationArguments for RegPhi {}
-impl OperationArguments for FlagPhi {}
-impl OperationArguments for MemPhi {}
-impl OperationArguments for Const {}
-impl OperationArguments for Extern {}
-impl OperationArguments for BinaryOp {}
-impl OperationArguments for BinaryOpCarry {}
-impl OperationArguments for DoublePrecDivOp {}
-impl OperationArguments for UnaryOp {}
-impl OperationArguments for Condition {}
-impl OperationArguments for UnimplMem {}