[Rust] Reduce usage of `IntoCStr` in function signatures

This is being done to reduce complexity in function signatures, specifically many of the strings we are passing ultimately should be new types themselves instead of "just strings", things such as type ids.

Another place which was confusing was dealing with filesystem related APIs, this commit turns most of those params into a stricter `Path` type.

This is bringing the rust api more inline with both python and C++, where the wrapper eagerly converts the string into the languages standard string type.

Special consideration must be made for symbols or other possible non utf-8 objects.

This commit will be followed up with one that adds the `IntoCStr` bound on API's we want to keep as invalid utf-8 so we can for example, get section by name on a section with invalid utf-8.

1 files changed, 8 insertions, 8 deletions

diff --git a/rust/src/medium_level_il/function.rs b/rust/src/medium_level_il/function.rs
index 0b88c166..bdbe3159 100644
--- a/rust/src/medium_level_il/function.rs
+++ b/rust/src/medium_level_il/function.rs
@@ -121,11 +121,11 @@ impl MediumLevelILFunction {
         unsafe { Array::new(raw_instr_idxs, count, self.to_owned()) }
     }
 
-    pub fn create_user_stack_var<'a, S: IntoCStr, C: Into<Conf<&'a Type>>>(
+    pub fn create_user_stack_var<'a, C: Into<Conf<&'a Type>>>(
         self,
         offset: i64,
         var_type: C,
-        name: S,
+        name: &str,
     ) {
         let mut owned_raw_var_ty = Conf::<&Type>::into_raw(var_type.into());
         let name = name.to_cstr();
@@ -143,11 +143,11 @@ impl MediumLevelILFunction {
         unsafe { BNDeleteUserStackVariable(self.function().handle, offset) }
     }
 
-    pub fn create_user_var<'a, S: IntoCStr, C: Into<Conf<&'a Type>>>(
+    pub fn create_user_var<'a, C: Into<Conf<&'a Type>>>(
         &self,
         var: &Variable,
         var_type: C,
-        name: S,
+        name: &str,
         ignore_disjoint_uses: bool,
     ) {
         let raw_var = BNVariable::from(var);
@@ -273,11 +273,11 @@ impl MediumLevelILFunction {
         Ok(())
     }
 
-    pub fn create_auto_stack_var<'a, T: Into<Conf<&'a Type>>, S: IntoCStr>(
+    pub fn create_auto_stack_var<'a, T: Into<Conf<&'a Type>>>(
         &self,
         offset: i64,
         var_type: T,
-        name: S,
+        name: &str,
     ) {
         let mut owned_raw_var_ty = Conf::<&Type>::into_raw(var_type.into());
         let name = name.to_cstr();
@@ -295,11 +295,11 @@ impl MediumLevelILFunction {
         unsafe { BNDeleteAutoStackVariable(self.function().handle, offset) }
     }
 
-    pub fn create_auto_var<'a, S: IntoCStr, C: Into<Conf<&'a Type>>>(
+    pub fn create_auto_var<'a, C: Into<Conf<&'a Type>>>(
         &self,
         var: &Variable,
         var_type: C,
-        name: S,
+        name: &str,
         ignore_disjoint_uses: bool,
     ) {
         let raw_var = BNVariable::from(var);