summaryrefslogtreecommitdiff
path: root/rust/src/project
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2025-05-03 23:15:17 -0400
committerMason Reed <35282038+emesare@users.noreply.github.com>2025-05-12 17:45:24 -0400
commit6264254065bbae9d89f51cf3330379b7ace09592 (patch)
tree9ece1d1739215c2faef2d808ef4fdc019ad527fa /rust/src/project
parentc3fdda9727f5507818e3f55576ad32215a22b0f9 (diff)
[Rust] Return `String` instead of `BnString` for cases where lossy conversion can be tolerated
Still need to go and audit all usage, but realistically the most important places to give the user control are with symbols, where the data can come from non utf8 sources This is still incomplete, I just looked for usage of -> BnString so any other variant was omitted.
Diffstat (limited to 'rust/src/project')
-rw-r--r--rust/src/project/file.rs16
-rw-r--r--rust/src/project/folder.rs12
2 files changed, 14 insertions, 14 deletions
diff --git a/rust/src/project/file.rs b/rust/src/project/file.rs
index 5071dd50..35f25937 100644
--- a/rust/src/project/file.rs
+++ b/rust/src/project/file.rs
@@ -37,8 +37,8 @@ impl ProjectFile {
}
/// Get the path on disk to this file's contents
- pub fn path_on_disk(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFileGetPathOnDisk(self.handle.as_ptr())) }
+ pub fn path_on_disk(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFileGetPathOnDisk(self.handle.as_ptr())) }
}
/// Check if this file's contents exist on disk
@@ -47,13 +47,13 @@ impl ProjectFile {
}
/// Get the unique id of this file
- pub fn id(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFileGetId(self.handle.as_ptr())) }
+ pub fn id(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFileGetId(self.handle.as_ptr())) }
}
/// Get the name of this file
- pub fn name(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFileGetName(self.handle.as_ptr())) }
+ pub fn name(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFileGetName(self.handle.as_ptr())) }
}
/// Set the name of this file
@@ -68,8 +68,8 @@ impl ProjectFile {
}
/// Get the description of this file
- pub fn description(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFileGetDescription(self.handle.as_ptr())) }
+ pub fn description(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFileGetDescription(self.handle.as_ptr())) }
}
/// Set the description of this file
diff --git a/rust/src/project/folder.rs b/rust/src/project/folder.rs
index 90b40051..316abeaf 100644
--- a/rust/src/project/folder.rs
+++ b/rust/src/project/folder.rs
@@ -36,13 +36,13 @@ impl ProjectFolder {
}
/// Get the unique id of this folder
- pub fn id(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFolderGetId(self.handle.as_ptr())) }
+ pub fn id(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFolderGetId(self.handle.as_ptr())) }
}
/// Get the name of this folder
- pub fn name(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFolderGetName(self.handle.as_ptr())) }
+ pub fn name(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFolderGetName(self.handle.as_ptr())) }
}
/// Set the name of this folder
@@ -57,8 +57,8 @@ impl ProjectFolder {
}
/// Get the description of this folder
- pub fn description(&self) -> BnString {
- unsafe { BnString::from_raw(BNProjectFolderGetDescription(self.handle.as_ptr())) }
+ pub fn description(&self) -> String {
+ unsafe { BnString::into_string(BNProjectFolderGetDescription(self.handle.as_ptr())) }
}
/// Set the description of this folder