diff options
| author | KyleMiles <krm504@nyu.edu> | 2023-02-06 21:50:09 -0500 |
|---|---|---|
| committer | KyleMiles <krm504@nyu.edu> | 2023-02-06 21:50:09 -0500 |
| commit | c2f7f8acadb4aec2c4df646528692fc9bfe1abd1 (patch) | |
| tree | ea59c8857feb37a9c07a8dc9c5d39648bfd30146 /rust/src | |
| parent | 60422cdbb250e1b4ba7f342efde6f505bbe75cf9 (diff) | |
Rust API: Clippy cleanup
Diffstat (limited to 'rust/src')
| -rw-r--r-- | rust/src/interaction.rs | 38 | ||||
| -rw-r--r-- | rust/src/logger.rs | 2 |
2 files changed, 14 insertions, 26 deletions
diff --git a/rust/src/interaction.rs b/rust/src/interaction.rs index 926a6e68..c6aada61 100644 --- a/rust/src/interaction.rs +++ b/rust/src/interaction.rs @@ -179,7 +179,7 @@ pub struct FormInputBuilder { data: Vec<FormData>, } -impl<'a> FormInputBuilder { +impl FormInputBuilder { pub fn new() -> Self { Self { fields: vec![], @@ -213,11 +213,7 @@ impl<'a> FormInputBuilder { /// Form Field: Prompt for a string value pub fn text_field(mut self, prompt: &str, default: Option<&str>) -> Self { let prompt = BnString::new(prompt); - let default = if let Some(default) = default { - Some(BnString::new(default)) - } else { - None - }; + let default = default.map(BnString::new); let mut result = unsafe { std::mem::zeroed::<BNFormInputField>() }; result.type_ = BNFormInputFieldType::TextLineFormField; @@ -238,11 +234,7 @@ impl<'a> FormInputBuilder { /// Form Field: Prompt for multi-line string value pub fn multiline_field(mut self, prompt: &str, default: Option<&str>) -> Self { let prompt = BnString::new(prompt); - let default = if let Some(default) = default { - Some(BnString::new(default)) - } else { - None - }; + let default = default.map(BnString::new); let mut result = unsafe { std::mem::zeroed::<BNFormInputField>() }; result.type_ = BNFormInputFieldType::MultilineTextFormField; @@ -345,11 +337,7 @@ impl<'a> FormInputBuilder { } else { BnString::new("") }; - let default = if let Some(default) = default { - Some(BnString::new(default)) - } else { - None - }; + let default = default.map(BnString::new); let mut result = unsafe { std::mem::zeroed::<BNFormInputField>() }; result.type_ = BNFormInputFieldType::OpenFileNameFormField; @@ -388,11 +376,7 @@ impl<'a> FormInputBuilder { } else { BnString::new("") }; - let default = if let Some(default) = default { - Some(BnString::new(default)) - } else { - None - }; + let default = default.map(BnString::new); let mut result = unsafe { std::mem::zeroed::<BNFormInputField>() }; result.type_ = BNFormInputFieldType::SaveFileNameFormField; @@ -427,11 +411,7 @@ impl<'a> FormInputBuilder { } else { BnString::new("") }; - let default = if let Some(default) = default { - Some(BnString::new(default)) - } else { - None - }; + let default = default.map(BnString::new); let mut result = unsafe { std::mem::zeroed::<BNFormInputField>() }; result.type_ = BNFormInputFieldType::DirectoryNameFormField; @@ -530,6 +510,12 @@ impl<'a> FormInputBuilder { } } +impl Default for FormInputBuilder { + fn default() -> Self { + Self::new() + } +} + struct TaskContext<F: Fn(Box<dyn Fn(usize, usize) -> Result<(), ()>>)>(F); pub fn run_progress_dialog<F: Fn(Box<dyn Fn(usize, usize) -> Result<(), ()>>)>( diff --git a/rust/src/logger.rs b/rust/src/logger.rs index eab0c647..7df87c93 100644 --- a/rust/src/logger.rs +++ b/rust/src/logger.rs @@ -1,3 +1,5 @@ +#![allow(clippy::needless_doctest_main)] + //! To use logging in your script, do something like: //! //! ``` |
