diff options
| author | Rusty Wagner <rusty.wagner@gmail.com> | 2025-06-24 17:55:48 -0400 |
|---|---|---|
| committer | Alexander Taylor <alex@vector35.com> | 2025-06-25 18:36:47 -0400 |
| commit | c41f264a1dba68c89b4a224a70e3a5783f7fa879 (patch) | |
| tree | 00bb6e91d86b708bff7265ed7179a6ef2793b7fb /type.cpp | |
| parent | b1a7666164a000c5255f90568ed9597b58ce276a (diff) | |
Remove implicit conversions from Confidence to underlying type, these can cause bugs and also issues with C++20
Diffstat (limited to 'type.cpp')
| -rw-r--r-- | type.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -976,7 +976,7 @@ Ref<Type> Type::FunctionType(const Confidence<Ref<Type>>& returnValue, returnValueConf.confidence = returnValue.GetConfidence(); BNCallingConventionWithConfidence callingConventionConf; - callingConventionConf.convention = callingConvention ? callingConvention->GetObject() : nullptr; + callingConventionConf.convention = callingConvention.GetValue() ? callingConvention->GetObject() : nullptr; callingConventionConf.confidence = callingConvention.GetConfidence(); BNFunctionParameter* paramArray = new BNFunctionParameter[params.size()]; @@ -1036,7 +1036,7 @@ Ref<Type> Type::FunctionType(const Confidence<Ref<Type>>& returnValue, returnValueConf.confidence = returnValue.GetConfidence(); BNCallingConventionWithConfidence callingConventionConf; - callingConventionConf.convention = callingConvention ? callingConvention->GetObject() : nullptr; + callingConventionConf.convention = callingConvention.GetValue() ? callingConvention->GetObject() : nullptr; callingConventionConf.confidence = callingConvention.GetConfidence(); BNFunctionParameter* paramArray = new BNFunctionParameter[params.size()]; @@ -1981,7 +1981,7 @@ TypeBuilder TypeBuilder::FunctionType(const Confidence<Ref<Type>>& returnValue, returnValueConf.confidence = returnValue.GetConfidence(); BNCallingConventionWithConfidence callingConventionConf; - callingConventionConf.convention = callingConvention ? callingConvention->GetObject() : nullptr; + callingConventionConf.convention = callingConvention.GetValue() ? callingConvention->GetObject() : nullptr; callingConventionConf.confidence = callingConvention.GetConfidence(); size_t paramCount = 0; @@ -2032,7 +2032,7 @@ TypeBuilder TypeBuilder::FunctionType(const Confidence<Ref<Type>>& returnValue, returnValueConf.confidence = returnValue.GetConfidence(); BNCallingConventionWithConfidence callingConventionConf; - callingConventionConf.convention = callingConvention ? callingConvention->GetObject() : nullptr; + callingConventionConf.convention = callingConvention.GetValue() ? callingConvention->GetObject() : nullptr; callingConventionConf.confidence = callingConvention.GetConfidence(); BNFunctionParameter* paramArray = new BNFunctionParameter[params.size()]; |