diff options
| author | Josh Ferrell <josh@vector35.com> | 2024-01-08 13:08:39 -0500 |
|---|---|---|
| committer | Josh Ferrell <josh@vector35.com> | 2024-01-08 13:08:39 -0500 |
| commit | 5e08d0b323e05642783808d22f3e21d3dfbb5ee2 (patch) | |
| tree | 8843f797685318ee622ae315d686ace1ab66dd0b /ui/memorymap.h | |
| parent | 869785ff2ee9b83731b9f8451f8aa4372d74c31e (diff) | |
Fix crash when adding segments/sections while memory map is open
Diffstat (limited to 'ui/memorymap.h')
| -rw-r--r-- | ui/memorymap.h | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/ui/memorymap.h b/ui/memorymap.h index 08d0dd51..5ae7c6e4 100644 --- a/ui/memorymap.h +++ b/ui/memorymap.h @@ -126,14 +126,15 @@ public: void highlightRelatedSegments(SectionRef section); void itemChanged(QTableWidgetItem* current, QTableWidgetItem* previous); - virtual void OnSegmentAdded(BinaryNinja::BinaryView* data, BinaryNinja::Segment* segment) override { updateInfo(); }; - virtual void OnSegmentUpdated(BinaryNinja::BinaryView* data, BinaryNinja::Segment* segment) override { updateInfo(); }; - virtual void OnSegmentRemoved(BinaryNinja::BinaryView* data, BinaryNinja::Segment* segment) override { updateInfo(); }; + virtual void OnSegmentAdded(BinaryNinja::BinaryView* data, BinaryNinja::Segment* segment) override; + virtual void OnSegmentUpdated(BinaryNinja::BinaryView* data, BinaryNinja::Segment* segment) override; + virtual void OnSegmentRemoved(BinaryNinja::BinaryView* data, BinaryNinja::Segment* segment) override; Q_SIGNALS: void currentSegmentChanged(SegmentRef current); void addressDoubleClicked(uint64_t address); void rawAddressDoubleClicked(uint64_t address); + void segmentsChanged(); }; /*! @@ -171,13 +172,14 @@ public: void highlightRelatedSections(SegmentRef segment); void itemChanged(QTableWidgetItem* current, QTableWidgetItem* previous); - virtual void OnSectionAdded(BinaryNinja::BinaryView* data, BinaryNinja::Section* section) override { updateInfo(); }; - virtual void OnSectionUpdated(BinaryNinja::BinaryView* data, BinaryNinja::Section* section) override { updateInfo(); }; - virtual void OnSectionRemoved(BinaryNinja::BinaryView* data, BinaryNinja::Section* section) override { updateInfo(); }; + virtual void OnSectionAdded(BinaryNinja::BinaryView* data, BinaryNinja::Section* section) override; + virtual void OnSectionUpdated(BinaryNinja::BinaryView* data, BinaryNinja::Section* section) override; + virtual void OnSectionRemoved(BinaryNinja::BinaryView* data, BinaryNinja::Section* section) override; Q_SIGNALS: void currentSectionChanged(SectionRef current); void addressDoubleClicked(uint64_t address); + void sectionsChanged(); }; // I hate C++ @@ -284,4 +286,4 @@ class BINARYNINJAUIAPI MemoryMapSidebarWidgetType : public SidebarWidgetType public: MemoryMapSidebarWidgetType(); SidebarWidget* createWidget(ViewFrame* frame, BinaryViewRef data) override; -};
\ No newline at end of file +}; |