summaryrefslogtreecommitdiff
path: root/view/macho/machoview.cpp
diff options
context:
space:
mode:
authorkat <kat@vector35.com>2024-07-26 03:36:56 -0400
committerkat <kat@vector35.com>2024-09-26 14:59:40 -0400
commit1a8c33332b10ea867d7e747b675ae615228a4b8a (patch)
tree54847743e761fbd90e31e0d3a83f799b9d08fc08 /view/macho/machoview.cpp
parentd5dbb30ffc81ebb8a6d47b6baef9ddcb954db717 (diff)
Clean up unused variables in Mach-O/Obj-C code
Diffstat (limited to 'view/macho/machoview.cpp')
-rw-r--r--view/macho/machoview.cpp13
1 files changed, 0 insertions, 13 deletions
diff --git a/view/macho/machoview.cpp b/view/macho/machoview.cpp
index 4859d73d..d8a8a57f 100644
--- a/view/macho/machoview.cpp
+++ b/view/macho/machoview.cpp
@@ -2579,13 +2579,11 @@ void MachoView::ParseRebaseTable(BinaryReader& reader, MachOHeader& header, uint
BNRelocationInfo rebaseRelocation;
- RebaseType type = RebaseTypeInvalid;
uint64_t segmentIndex = 0;
uint64_t address = segmentActualLoadAddress(0);
uint64_t segmentStartAddress = segmentActualLoadAddress(0);
uint64_t segmentEndAddress = segmentActualEndAddress(0);
uint64_t count;
- uint64_t size;
uint64_t skip;
bool done = false;
size_t i = 0;
@@ -2602,7 +2600,6 @@ void MachoView::ParseRebaseTable(BinaryReader& reader, MachOHeader& header, uint
done = true;
break;
case RebaseOpcodeSetTypeImmediate:
- type = (RebaseType)immediate;
break;
case RebaseOpcodeSetSegmentAndOffsetUleb:
segmentIndex = immediate;
@@ -2905,11 +2902,6 @@ void MachoView::ParseSymbolTable(BinaryReader& reader, MachOHeader& header, cons
size_t needed = symbolStubs.size / symbolStubs.reserved2;
for (size_t j = 0; (j < needed) && ((j + symbolStubs.reserved1) < indirectSymbols.size()); j++)
{
- // Not exactly sure what the following 3 variables are for but this is the check done in
- // Apple's source code
- uint8_t sectionType = (symbolStubs.flags & SECTION_TYPE);
- bool selfModifyingStub = (sectionType == S_SYMBOL_STUBS) && (symbolStubs.flags & S_ATTR_SELF_MODIFYING_CODE) &&
- (symbolStubs.reserved2 == 5) && (header.ident.cputype == MACHO_CPU_TYPE_X86);
auto symNum = indirectSymbols[j + symbolStubs.reserved1];
if (symNum == INDIRECT_SYMBOL_ABS)
continue;
@@ -2924,11 +2916,6 @@ void MachoView::ParseSymbolTable(BinaryReader& reader, MachOHeader& header, cons
unordered_map<size_t, vector<std::pair<section_64*, size_t>>> pointerSymbols;
for (auto& symbolPointerSection : header.symbolPointerSections)
{
- // Not exactly sure what the following 3 variables are for but this is the check done in
- // Apple's source code
- uint8_t sectionType = (symbolPointerSection.flags & SECTION_TYPE);
- bool selfModifyingStub = (sectionType == S_SYMBOL_STUBS) && (symbolPointerSection.flags & S_ATTR_SELF_MODIFYING_CODE) &&
- (symbolPointerSection.reserved2 == 5) && (header.ident.cputype == MACHO_CPU_TYPE_X86);
size_t needed = symbolPointerSection.size / m_addressSize;
for (size_t j = 0; (j < needed) && ((j + symbolPointerSection.reserved1) < indirectSymbols.size()); j++)
{