summaryrefslogtreecommitdiff
path: root/view/macho
diff options
context:
space:
mode:
authorPeter LaFosse <peter@vector35.com>2025-01-15 15:02:39 -0500
committerPeter LaFosse <peter@vector35.com>2025-01-15 15:03:07 -0500
commit362a420eb027bd1de0a172f1823ba7e4dd806a3a (patch)
tree691895d8b8b3203eb3dc09f978b4d244f2deeff1 /view/macho
parentb14f86d5373eb7a4a8a40c9a23c3a9faf2732eeb (diff)
Remove unused calls to defineTypedef which were causing hangs
Diffstat (limited to 'view/macho')
-rw-r--r--view/macho/objc.cpp19
-rw-r--r--view/macho/objc.h14
2 files changed, 17 insertions, 16 deletions
diff --git a/view/macho/objc.cpp b/view/macho/objc.cpp
index adf8eb80..d5d417a5 100644
--- a/view/macho/objc.cpp
+++ b/view/macho/objc.cpp
@@ -1196,16 +1196,17 @@ void ObjCProcessor::ProcessObjCData()
m_symbolQueue = new SymbolQueue();
auto addrSize = m_data->GetAddressSize();
- m_typeNames.relativePtr = defineTypedef(m_data, {"rptr_t"}, Type::IntegerType(4, true));
- auto rptr_t = Type::NamedType(m_data, m_typeNames.relativePtr);
+ // m_typeNames.relativePtr = defineTypedef(m_data, {"rptr_t"}, Type::IntegerType(4, true));
+ // auto rptr_t = Type::NamedType(m_data, m_typeNames.relativePtr);
+ auto rptr_t = Type::NamedType(m_data, defineTypedef(m_data, {"rptr_t"}, Type::IntegerType(4, true)));
- m_typeNames.id = defineTypedef(m_data, {"id"}, Type::PointerType(addrSize, Type::VoidType()));
- m_typeNames.sel = defineTypedef(m_data, {"SEL"}, Type::PointerType(addrSize, Type::IntegerType(1, false)));
-
- m_typeNames.BOOL = defineTypedef(m_data, {"BOOL"}, Type::IntegerType(1, false));
- m_typeNames.nsInteger = defineTypedef(m_data, {"NSInteger"}, Type::IntegerType(addrSize, true));
- m_typeNames.nsuInteger = defineTypedef(m_data, {"NSUInteger"}, Type::IntegerType(addrSize, false));
- m_typeNames.cgFloat = defineTypedef(m_data, {"CGFloat"}, Type::FloatType(addrSize));
+ // m_typeNames.id = defineTypedef(m_data, {"id"}, Type::PointerType(addrSize, Type::VoidType()));
+ // m_typeNames.sel = defineTypedef(m_data, {"SEL"}, Type::PointerType(addrSize, Type::IntegerType(1, false)));
+ //
+ // m_typeNames.BOOL = defineTypedef(m_data, {"BOOL"}, Type::IntegerType(1, false));
+ // m_typeNames.nsInteger = defineTypedef(m_data, {"NSInteger"}, Type::IntegerType(addrSize, true));
+ // m_typeNames.nsuInteger = defineTypedef(m_data, {"NSUInteger"}, Type::IntegerType(addrSize, false));
+ // m_typeNames.cgFloat = defineTypedef(m_data, {"CGFloat"}, Type::FloatType(addrSize));
// https://github.com/apple-oss-distributions/objc4/blob/196363c165b175ed925ef6b9b99f558717923c47/runtime/objc-abi.h
EnumerationBuilder imageInfoFlagBuilder;
diff --git a/view/macho/objc.h b/view/macho/objc.h
index 639705ad..452cfed0 100644
--- a/view/macho/objc.h
+++ b/view/macho/objc.h
@@ -147,13 +147,13 @@ namespace BinaryNinja {
class ObjCProcessor {
struct Types {
- QualifiedName relativePtr;
- QualifiedName id;
- QualifiedName sel;
- QualifiedName BOOL;
- QualifiedName nsInteger;
- QualifiedName nsuInteger;
- QualifiedName cgFloat;
+ // QualifiedName relativePtr;
+ // QualifiedName id;
+ // QualifiedName sel;
+ // QualifiedName BOOL;
+ // QualifiedName nsInteger;
+ // QualifiedName nsuInteger;
+ // QualifiedName cgFloat;
QualifiedName cfStringFlag;
QualifiedName cfString;
QualifiedName cfStringUTF16;