[SharedCache] Use StringRef for performance

3 files changed, 4 insertions, 3 deletions

diff --git a/view/sharedcache/api/sharedcache.cpp b/view/sharedcache/api/sharedcache.cpp
index 472bb024..2b5ba744 100644
--- a/view/sharedcache/api/sharedcache.cpp
+++ b/view/sharedcache/api/sharedcache.cpp
@@ -165,7 +165,7 @@ namespace SharedCacheAPI {
 		{
 			DSCSymbol sym;
 			sym.address = value[i].address;
-			sym.name = value[i].name;
+			sym.name = StringRef(BNDuplicateStringRef(value[i].name));
 			sym.image = value[i].image;
 			result.push_back(sym);
 		}
diff --git a/view/sharedcache/api/sharedcacheapi.h b/view/sharedcache/api/sharedcacheapi.h
index 50d2b382..712cc98e 100644
--- a/view/sharedcache/api/sharedcacheapi.h
+++ b/view/sharedcache/api/sharedcacheapi.h
@@ -126,7 +126,7 @@ namespace SharedCacheAPI {
 
 	struct DSCSymbol {
 		uint64_t address;
-		std::string name;
+		BinaryNinja::StringRef name;
 		std::string image;
 	};
 
diff --git a/view/sharedcache/api/sharedcachecore.h b/view/sharedcache/api/sharedcachecore.h
index 155f39de..c2e1c7bd 100644
--- a/view/sharedcache/api/sharedcachecore.h
+++ b/view/sharedcache/api/sharedcachecore.h
@@ -66,6 +66,7 @@ extern "C"
 
 	typedef struct BNBinaryView BNBinaryView;
 	typedef struct BNSharedCache BNSharedCache;
+	typedef struct BNStringRef BNStringRef;
 
 	typedef struct BNDSCImageMemoryMapping {
 		char* filePath;
@@ -109,7 +110,7 @@ extern "C"
 
 	typedef struct BNDSCSymbolRep {
 		uint64_t address;
-		char* name;
+		BNStringRef* name;
 		char* image;
 	} BNDSCSymbolRep;