[SharedCache] Replace write log with callback registration for reapplying slide info

This improves performance by ~10x with the only real issue being a copy of the cache entry existing for each weak ref.

Also fixes
- Some old TODO's that are no longer relevant
- Some function signatures not being const
- FileAccessorCache not evicting enough accessors to fit under an adjusted cache size
- Added a warning if we are over the global cache size in view initialization
- Logger name not having a `.` in `SlideInfoProcessor::SlideInfoProcessor`
- Re-added the accessor dirty check before applying slide info to fix https://github.com/Vector35/binaryninja-api/issues/6570

1 files changed, 3 insertions, 3 deletions

diff --git a/view/sharedcache/core/SlideInfo.h b/view/sharedcache/core/SlideInfo.h
index bc165589..75134985 100644
--- a/view/sharedcache/core/SlideInfo.h
+++ b/view/sharedcache/core/SlideInfo.h
@@ -33,10 +33,10 @@ class SlideInfoProcessor
 public:
 	explicit SlideInfoProcessor(uint64_t baseAddress);
 
-	std::vector<SlideMappingInfo> ReadEntryInfo(VirtualMemory& vm, const CacheEntry& entry) const;
+	std::vector<SlideMappingInfo> ReadEntryInfo(const MappedFileAccessor& accessor, const CacheEntry& entry) const;
 
 	// Write the slide information back to the entries memory mapped regions.
-	void ApplyMappings(VirtualMemory& vm, const std::vector<SlideMappingInfo>& mappings);
+	void ApplyMappings(MappedFileAccessor& accessor, const std::vector<SlideMappingInfo>& mappings) const;
 
-	void ProcessEntry(VirtualMemory& vm, const CacheEntry& entry);
+	std::vector<SlideMappingInfo> ProcessEntry(MappedFileAccessor& accessor, const CacheEntry& entry) const;
 };