[SharedCache] Replace write log with callback registration for reapplying slide info

This improves performance by ~10x with the only real issue being a copy of the cache entry existing for each weak ref.

Also fixes
- Some old TODO's that are no longer relevant
- Some function signatures not being const
- FileAccessorCache not evicting enough accessors to fit under an adjusted cache size
- Added a warning if we are over the global cache size in view initialization
- Logger name not having a `.` in `SlideInfoProcessor::SlideInfoProcessor`
- Re-added the accessor dirty check before applying slide info to fix https://github.com/Vector35/binaryninja-api/issues/6570

1 files changed, 1 insertions, 4 deletions

diff --git a/view/sharedcache/core/VirtualMemory.h b/view/sharedcache/core/VirtualMemory.h
index 43a9acb4..2edc6ef3 100644
--- a/view/sharedcache/core/VirtualMemory.h
+++ b/view/sharedcache/core/VirtualMemory.h
@@ -55,10 +55,7 @@ public:
 
 	bool IsAddressMapped(uint64_t address);
 
-	// TODO: Bulk pointer writes here would alleviate a lot of the time spent in the slide info processor.
-	// Write a pointer at a given address. This pointer will be persisted
-	// for a given `VirtualMemoryRegion` region, unlike using the MappedFileAccessor directly.
-	// The persistence is provided through the WeakFileAccessor itself and thus is unique to the construction.
+	// Write a pointer at a given address. This pointer is never persisted when a file accessor is closed.
 	void WritePointer(size_t address, size_t pointer);
 
 	std::string ReadCString(uint64_t address);