summaryrefslogtreecommitdiff
path: root/view/sharedcache/core
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2025-02-11 21:55:32 -0500
committerMason Reed <mason@vector35.com>2025-02-12 18:43:02 -0500
commitacea6d4a7bb2cef1f84c68c3687331534fe1ede1 (patch)
tree3230328c5b0d2167c8227f23683089e49327c9d2 /view/sharedcache/core
parent8dd4e14da7ddd182a7fd9ea9437b7135f0c5cd9e (diff)
[SharedCache] Fix designator order for fields
This apparently is not an issue on LLVM, but GCC and MSVC both seem to dislike this.
Diffstat (limited to 'view/sharedcache/core')
-rw-r--r--view/sharedcache/core/SharedCache.h11
1 files changed, 6 insertions, 5 deletions
diff --git a/view/sharedcache/core/SharedCache.h b/view/sharedcache/core/SharedCache.h
index 1ecfd885..19445dd9 100644
--- a/view/sharedcache/core/SharedCache.h
+++ b/view/sharedcache/core/SharedCache.h
@@ -51,6 +51,7 @@ namespace SharedCacheCore {
.MSL(size),
.MSL(loaded),
.MSL(rawViewOffsetIfLoaded),
+ .headerInitialized = false, // NOTE: I guess this is not stored?
.MSL_CAST(flags, uint64_t, BNSegmentFlag),
};
}
@@ -443,7 +444,7 @@ namespace SharedCacheCore {
MSS_SUBCLASS(symtab);
MSS_SUBCLASS(dysymtab);
MSS_SUBCLASS(dyldInfo);
- // MSS_SUBCLASS(routines64);
+ MSS_SUBCLASS(routines64);
MSS_SUBCLASS(functionStarts);
MSS_SUBCLASS(moduleInitSections);
MSS_SUBCLASS(exportTrie);
@@ -458,8 +459,8 @@ namespace SharedCacheCore {
MSS(dylibs);
MSS_SUBCLASS(buildVersion);
MSS_SUBCLASS(buildToolVersions);
- MSS(linkeditPresent);
MSS(exportTriePath);
+ MSS(linkeditPresent);
MSS(dysymPresent);
MSS(dyldInfoPresent);
MSS(exportTriePresent);
@@ -481,7 +482,7 @@ namespace SharedCacheCore {
.MSL(symtab),
.MSL(dysymtab),
.MSL(dyldInfo),
- // .MSL(routines64), // FIXME CRASH but also do we even use this?
+ .MSL(routines64), // TODO: This supposedly caused a crash on some binary? Need a repro.
.MSL(functionStarts),
.MSL(moduleInitSections),
.MSL(exportTrie),
@@ -496,13 +497,13 @@ namespace SharedCacheCore {
.MSL(dylibs),
.MSL(buildVersion),
.MSL(buildToolVersions),
- .MSL(linkeditPresent),
.MSL(exportTriePath),
+ .MSL(linkeditPresent),
.MSL(dysymPresent),
.MSL(dyldInfoPresent),
.MSL(exportTriePresent),
.MSL(chainedFixupsPresent),
- // .MSL(routinesPresent),
+ .MSL(routinesPresent),
.MSL(functionStartsPresent),
.MSL(relocatable),
};