summaryrefslogtreecommitdiff
path: root/view/sharedcache
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2025-04-02 09:00:27 -0400
committerMason Reed <mason@vector35.com>2025-04-02 10:27:32 -0400
commit1df51b212d4b91fdac6d15c9cb4aac759b94394a (patch)
tree783c3e796e1acd5d2f1a8e8636dae539a355f01d /view/sharedcache
parent3fddd350deb670ede85a59d9213296f1f9618920 (diff)
[SharedCache] Misc formatting
Diffstat (limited to 'view/sharedcache')
-rw-r--r--view/sharedcache/core/SharedCacheView.cpp1
-rw-r--r--view/sharedcache/workflow/SharedCacheWorkflow.cpp5
2 files changed, 2 insertions, 4 deletions
diff --git a/view/sharedcache/core/SharedCacheView.cpp b/view/sharedcache/core/SharedCacheView.cpp
index 0d9b0e70..43dc63ff 100644
--- a/view/sharedcache/core/SharedCacheView.cpp
+++ b/view/sharedcache/core/SharedCacheView.cpp
@@ -794,7 +794,6 @@ bool SharedCacheView::Init()
// TODO: Prompt the user to select the primary cache file? We can still recover from here.
// Oh no, we failed to process the cache, this likely means the primary on-disk file was not able to be found.
logger->LogError("Failed to process cache, likely missing cache files.");
- // TODO: Returning false here does not prevent the file from being opened.
// NOTE: An interaction handler headlessly could select yes to this, however for the purposes of this we will just let them continue by defualt.
if (IsUIEnabled() && ShowMessageBox("Continue opening", "This shared cache file was unable to be processed, would you like to open without shared cache information?", YesNoButtonSet, QuestionIcon) != YesButton)
return false;
diff --git a/view/sharedcache/workflow/SharedCacheWorkflow.cpp b/view/sharedcache/workflow/SharedCacheWorkflow.cpp
index b364ea2f..766164b8 100644
--- a/view/sharedcache/workflow/SharedCacheWorkflow.cpp
+++ b/view/sharedcache/workflow/SharedCacheWorkflow.cpp
@@ -171,8 +171,7 @@ void AnalyzeStubFunction(Ref<Function> func, Ref<MediumLevelILFunction> mlil, Sh
{
// First load the stub island, if we _do_ load the stub island stop and reanalyze for constant propagation.'
const auto islandPtr = expr.GetConstant<MLIL_CONST_PTR>();
- auto loaded = loadTarget(islandPtr);
- if (loaded)
+ if (loadTarget(islandPtr))
return;
// We have been promoted to the target pointer here!
const auto targetPtr = islandPtr;
@@ -190,7 +189,7 @@ void AnalyzeStubFunction(Ref<Function> func, Ref<MediumLevelILFunction> mlil, Sh
{
case MLIL_CONST_PTR:
// NOTE: This runs every single function update.
- func->SetAutoInlinedDuringAnalysis(true);
+ func->SetAutoInlinedDuringAnalysis(true);
break;
default:
break;