diff options
| author | Mason Reed <mason@vector35.com> | 2025-02-19 23:22:25 -0500 |
|---|---|---|
| committer | Mason Reed <mason@vector35.com> | 2025-04-02 05:36:54 -0400 |
| commit | abc72eb94ee5dd245cb50dd47da94e875f244b20 (patch) | |
| tree | 4e7b9ecc2156c6ae84a47dfc160c7444fc43a73f /view/sharedcache | |
| parent | 157c4a3134df6e8e19d0f932b9215c1a1317dbec (diff) | |
[SharedCache] Remove some dead code and misc lints
Diffstat (limited to 'view/sharedcache')
| -rw-r--r-- | view/sharedcache/core/SharedCache.cpp | 13 | ||||
| -rw-r--r-- | view/sharedcache/ui/SharedCacheUINotifications.cpp | 1 |
2 files changed, 3 insertions, 11 deletions
diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp index 5860be5d..6fe0dc24 100644 --- a/view/sharedcache/core/SharedCache.cpp +++ b/view/sharedcache/core/SharedCache.cpp @@ -1449,7 +1449,7 @@ SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) : return; } - sharedCacheReferences++; + ++sharedCacheReferences; INIT_SHAREDCACHE_API_OBJECT() if (!DeserializeFromRawView(lock)) { @@ -1494,7 +1494,7 @@ SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) : } SharedCache::~SharedCache() { - sharedCacheReferences--; + --sharedCacheReferences; } SharedCache* SharedCache::GetFromDSCView(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) @@ -3636,19 +3636,12 @@ std::string SharedCacheMetadata::InstallNameForImageBaseAddress(uint64_t baseAdd } // namespace SharedCacheCore -namespace { - -[[maybe_unused]] DSCViewType* g_dscViewType; - -} - void InitDSCViewType() { MMappedFileAccessor::InitialVMSetup(); std::atexit(VMShutdown); static DSCViewType type; BinaryViewType::Register(&type); - g_dscViewType = &type; } extern "C" @@ -3688,7 +3681,7 @@ extern "C" bool BNDSCViewLoadImageWithInstallName(BNSharedCache* cache, char* name, bool skipObjC) { std::string imageName = std::string(name); - // FIXME !!!!!!!! BNFreeString(name); + BNFreeString(name); if (cache->object) return cache->object->LoadImageWithInstallName(imageName, skipObjC); diff --git a/view/sharedcache/ui/SharedCacheUINotifications.cpp b/view/sharedcache/ui/SharedCacheUINotifications.cpp index 6979bac3..9d5893f9 100644 --- a/view/sharedcache/ui/SharedCacheUINotifications.cpp +++ b/view/sharedcache/ui/SharedCacheUINotifications.cpp @@ -48,7 +48,6 @@ void UINotifications::OnViewChange(UIContext* context, ViewFrame* frame, const Q if (!ah->isBoundAction("Load Image by Name")) { ah->bindAction("Load Image by Name", UIAction([view = view](const UIActionContext& ctx) { - Ref<SharedCacheAPI::SharedCache> cache = new SharedCacheAPI::SharedCache(view); DisplayDSCPicker(ctx.context, view); })); ah->bindAction("Load Section by Address", UIAction([view = view](const UIActionContext& ctx) { |