summaryrefslogtreecommitdiff
path: root/view
diff options
context:
space:
mode:
authorMason Reed <mason@vector35.com>2025-04-01 15:59:51 -0400
committerMason Reed <mason@vector35.com>2025-04-02 05:36:54 -0400
commit5552506894018ebc1ec5ae4d262d415dc6573ade (patch)
tree8db92c361fa3b6f92a7f64f832fc660bc9af331d /view
parent86bf8efada5c48ca339b4de3bcfed22b97e0e0bf (diff)
[SharedCache] Improper nesting in workflow
oops!
Diffstat (limited to 'view')
-rw-r--r--view/sharedcache/workflow/SharedCacheWorkflow.cpp30
1 files changed, 15 insertions, 15 deletions
diff --git a/view/sharedcache/workflow/SharedCacheWorkflow.cpp b/view/sharedcache/workflow/SharedCacheWorkflow.cpp
index 4c2f6d51..843194c6 100644
--- a/view/sharedcache/workflow/SharedCacheWorkflow.cpp
+++ b/view/sharedcache/workflow/SharedCacheWorkflow.cpp
@@ -368,25 +368,25 @@ void FixupOffImageCalls(Ref<AnalysisContext> ctx)
}
}
}
- else if (destExpr.operation == MLIL_CONST_PTR)
+ }
+ else if (destExpr.operation == MLIL_CONST_PTR)
+ {
+ // 4 @ 18aa08208 (MLIL_JUMP jump((MLIL_CONST_PTR.q 0x18c1369f0)))
+ auto targetAddr = destExpr.GetConstant();
+ if (!view->IsValidOffset(targetAddr))
{
- // 4 @ 18aa08208 (MLIL_JUMP jump((MLIL_CONST_PTR.q 0x18c1369f0)))
- auto targetAddr = destExpr.GetConstant();
- if (!view->IsValidOffset(targetAddr))
- {
- tryAddRegion(targetAddr);
- }
+ tryAddRegion(targetAddr);
}
- else if (destExpr.operation == MLIL_LOAD_SSA)
+ }
+ else if (destExpr.operation == MLIL_LOAD_SSA)
+ {
+ auto ptrExpr = destExpr.GetSourceExpr<MLIL_LOAD_SSA>();
+ if (ptrExpr.operation == MLIL_CONST_PTR)
{
- auto ptrExpr = destExpr.GetSourceExpr<MLIL_LOAD_SSA>();
- if (ptrExpr.operation == MLIL_CONST_PTR)
+ auto targetAddr = ptrExpr.GetConstant();
+ if (!view->IsValidOffset(targetAddr))
{
- auto targetAddr = ptrExpr.GetConstant();
- if (!view->IsValidOffset(targetAddr))
- {
- tryAddRegion(targetAddr);
- }
+ tryAddRegion(targetAddr);
}
}
}