summaryrefslogtreecommitdiff
path: root/rust/src/downloadprovider.rs
diff options
context:
space:
mode:
Diffstat (limited to 'rust/src/downloadprovider.rs')
-rw-r--r--rust/src/downloadprovider.rs8
1 files changed, 5 insertions, 3 deletions
diff --git a/rust/src/downloadprovider.rs b/rust/src/downloadprovider.rs
index 65a11dd0..dfc8b5e2 100644
--- a/rust/src/downloadprovider.rs
+++ b/rust/src/downloadprovider.rs
@@ -38,6 +38,8 @@ impl DownloadProvider {
Ok(unsafe { Array::new(list, count, ()) })
}
+ /// TODO : Clippy isn't happy...says we should `impl Default`....excessive error checking might be preventing us from doing so
+ #[allow(clippy::should_implement_trait)]
pub fn default() -> Result<DownloadProvider, ()> {
let s = Settings::new("");
let dp_name = s.get_string("network.downloadProviderName", None, None);
@@ -164,10 +166,10 @@ impl DownloadInstance {
// Drop it
unsafe { Box::from_raw(callbacks) };
if result < 0 {
- return Err(self.get_error());
+ Err(self.get_error())
+ } else {
+ Ok(())
}
-
- return Ok(());
}
unsafe extern "C" fn i_read_callback(data: *mut u8, len: u64, ctxt: *mut c_void) -> i64 {